Comments (7)
@annjawn Hi, thanks for reporting the issue. It maybe because we haven't used safe area
when doing layout.
from lightbox.
@annjawn Hi, can you check https://github.com/hyperoslo/Lightbox/releases/tag/2.1.0 ?
from lightbox.
Hi @onmyway133 , yes it's a safe area issue. I've been having a lot of trouble with safe area in my project and had to do multiple workarounds. There are issues with other libs that use controllers like this and I have raised issues and requested PRs with them and you are the only one who responded so fast and fixed it so thank you so much.
from lightbox.
@onmyway133 the latest update (2.1.0) is causing a crash at InfoLabel.swift
Reverted to 2.0.1 and the error was gone but back to the iPhone X layout issue.
from lightbox.
@annjawn I think this was the problem with truncating text with emoji, however I can't reproduce it. Do you have any detailed steps that I can reproduce ?
from lightbox.
@onmyway133 Hey man. I wasn't able to recreate the issue. BUT, this morning, I cloned your project and ran pod update
and after that I noticed that the Infolabel.swift
had a few differences than what's on my project. The sample project had this
var truncatedText: String {
var truncatedText = fullText
guard numberOfLines(fullText) > numberOfVisibleLines else {
return truncatedText
}
// Perform quick "rough cut"
while numberOfLines(truncatedText) > numberOfVisibleLines * 2 {
truncatedText = String(truncatedText.prefix(truncatedText.count / 2))
}
// Capture the endIndex of truncatedText before appending ellipsis
var truncatedTextCursor = truncatedText.endIndex
truncatedText += ellipsis
// Remove characters ahead of ellipsis until the text is the right number of lines
while numberOfLines(truncatedText) > numberOfVisibleLines {
// To avoid "Cannot decrement before startIndex"
guard truncatedTextCursor > truncatedText.startIndex else {
break
}
truncatedTextCursor = truncatedText.index(before: truncatedTextCursor)
truncatedText.remove(at: truncatedTextCursor)
}
return truncatedText
}
Where as my project had this
fileprivate var truncatedText: String {
var truncatedText = fullText
guard numberOfLines(fullText) > numberOfVisibleLines else {
return truncatedText
}
// Perform quick "rough cut"
while numberOfLines(truncatedText) > numberOfVisibleLines * 2 {
truncatedText = String(truncatedText.prefix(truncatedText.count / 2))
}
// Capture the endIndex of truncatedText before appending ellipsis
var truncatedTextCursor = truncatedText.endIndex
truncatedText += ellipsis
// Remove characters ahead of ellipsis until the text is the right number of lines
while numberOfLines(truncatedText) > numberOfVisibleLines {
truncatedTextCursor = truncatedText.index(before: truncatedTextCursor)
truncatedText.remove(at: truncatedTextCursor)
}
return truncatedText
}
I am not sure why because the pod is upto date but I took your changes in manually and now it works.
from lightbox.
@annjawn Hi, it was because of this PR #157 which was just merged into master. We will release new version soon. I will close this for now, as it was originally an issue regarding iPhone X
from lightbox.
Related Issues (20)
- Strat with specific index HOT 5
- Swipe Delegate HOT 1
- Close Programmaticly HOT 3
- Delete image HOT 3
- RTL SUPPORT HOT 1
- Images in fullscreen cover the close button, delete and page count
- Blank screen if media failed to load. HOT 1
- Animated GIF Support HOT 2
- Playing local videos not working.
- Feature Request: Please provide GIF support
- Installation with SPM fails HOT 1
- Delete Item Notification
- Multiple images and video in the array loop
- Presenting LightBoxController doesn't work. HOT 1
- replace imaginary with kingfisher library HOT 3
- this is cannot play youtube URL 😔 HOT 2
- LightBox won't resolve in SPM HOT 2
- Authentication Headers
- Download button HOT 7
- Development question HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lightbox.