Giter Club home page Giter Club logo

Comments (3)

hyln9 avatar hyln9 commented on June 16, 2024

refill-bv-buffer: lines 714-716 use j but should they be using c1?

Fixed. Thanks.

lookahead-char-utf8-mode: line 840 uses get-char but should it be?

Nop. It was supposed to be lookahead-char.

I know the port position stuff is not finished, but I noticed these:

refill-bv-buffer: lines 706-708: should refilling the buffer be
advancing the port's position?

Yes, that's the only place where the port-position field advances.

Should these give 0?

(input-port-byte-position (open-string-input-port "foobar"))
1
(input-port-byte-position (open-bytevector-input-port '#vu8(1 2 3
4 5)))
1

I don't know. I added the 1 explicitly in line 239 (vi bias again).
BTW, this is not the port-position of R6RS, right?

Aziz,,,

Launchpad Details: #LPC Abdulaziz Ghuloum - 2008-06-08 18:58:25 -0400

from ikarus.

hyln9 avatar hyln9 commented on June 16, 2024

Should these give 0?

(input-port-byte-position (open-string-input-port "foobar"))
1
(input-port-byte-position (open-bytevector-input-port '#vu8(1 2 3
4 5)))
1

I don't know. I added the 1 explicitly in line 239 (vi bias again).
BTW, this is not the port-position of R6RS, right?

Ah, I see where it's used now. My editor counts chars starting at 1 too, and all the character positions I've jumped to have been correct. I'm so used to thinking in 0-based indexing... :) just thought to mention it.

Launchpad Details: #LPC Derick Eddington - 2008-06-08 21:41:00 -0400

from ikarus.

hyln9 avatar hyln9 commented on June 16, 2024

I'm going to drop input-port-byte-position from the exports of (ikarus) because this is really an internal function.

Launchpad Details: #LPC Abdulaziz Ghuloum - 2008-06-09 04:30:26 -0400

from ikarus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.