Giter Club home page Giter Club logo

Comments (4)

smalluban avatar smalluban commented on September 26, 2024

I don't have time to check every TS error (from all of your issues) - can you confirm if the problem is solved by using TS v4?

FYI: #236 (comment)

from hybrids.

Qsppl avatar Qsppl commented on September 26, 2024

Update: In the first case, this is my mistake. I shouldn't have written

function toggleEdit(host: ISecondComponent) {
    host.editMode = true
    host.draft = host.model
    host.content().querySelector('input').focus()
}

but

function toggleEdit(host: Component<ISecondComponent>) {
    host.editMode = true
    host.draft = host.model
    host.content?.(host).querySelector('input').focus()
}

result:

import { Model, define, html, store, Component } from "https://esm.sh/[email protected]"

export interface IModel {
    prop1: number
}

export const ModelStore: Model<IModel> = {
    id: true,
    prop1: 1
}

function toggleEdit(host: Component<ISecondComponent>) {
    host.editMode = true
    host.draft = host.model
    host.content?.(host).querySelector('input').focus()
}

export interface ISecondComponent extends HTMLElement {
    model: IModel
    draft: IModel
    editMode: boolean
}

export default define<ISecondComponent>({
    tag: "a-second",
    model: store(ModelStore),
    draft: store(ModelStore, { draft: true }),
    editMode: {
        get: (host, lastValue) => !host.model || lastValue,
        set: (host, value, lastValue) => value,
    },
    content: ({ draft, model, editMode }) => html`
        ${editMode ? html`
            <form>
                <input value="${draft.prop1}" oninput="${html.set(draft, 'prop1')}" />
                <button type="submit">Save</button>
            </form>
        ` : html`
            ${store.ready(model) && html`<div>${model.prop1}</div>`}
            <div><button onclick="${toggleEdit}">Edit</button></div>
        `}
    `
})

With this fix on typescript 4.9.5, another error appears in the same place:
image
image

from hybrids.

smalluban avatar smalluban commented on September 26, 2024

Update your example with (it fixes the TS errors):

function toggleEdit(host: ISecondComponent) {
  host.editMode = true;
  host.draft = host.model;
  host.content().querySelector("input")?.focus();
}

export interface ISecondComponent extends HTMLElement {
  model: IModel;
  draft: IModel;
  editMode: boolean;
  content: () => ISecondComponent;
}

The argument of the toogleEdit is ISecondComponent, not Component<...> - this would be a definition, not an instance.

And if you want to use content or render directly, you must define those properties too in ISecondComponent, like you do for the rest of the properites.

from hybrids.

Qsppl avatar Qsppl commented on September 26, 2024

Thank you. This solved the problem.

from hybrids.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.