Comments (3)
husseycoding
commented on July 17, 2024
Can do yes, but I'm not entirely sure the fix is still relevant for the most recent versions of Magento as I haven't tested it and I know the class in question has changed in the core since I created this module. Do you know that this is still broken?
from cartrulefix.
seansan
commented on July 17, 2024
I am not sure, as I also dont know what you changed/where
Maybe have a check here: https://www.diffchecker.com/Dxr5Cam1 (link online
only today)
was diffed against:
https://github.com/OpenMage/magento-lts/blob/1.9.3.1/app/code/core/Mage/SalesRule/Model/Validator.php
maybe check once and then final as I see others also would like to know: is
this still a bug or not?
…On Thu, Feb 9, 2017 at 11:23 AM, Jonathan Hussey ***@***.***> wrote:
Can do yes, but I'm not entirely sure the fix is still relevant for the
most recent versions of Magento as I haven't tested it and I know the class
in question has changed in the core since I created this module. Do you
know that this is still broken?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAn0a846ZatmnDXWJcW0LG4dr-5f5Ng9ks5raukMgaJpZM4L75sX>
.
from cartrulefix.
husseycoding
commented on July 17, 2024
I would say the easiest way is to check whether functionality described in the bug report linked to from the module description is still broken in the latest version.
from cartrulefix.
Related Issues (4)
- Magento CE 1.9.2 HOT 4
- test
- Not working in 1.9.2.1 magento HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cartrulefix.