Giter Club home page Giter Club logo

Comments (3)

hurlenko avatar hurlenko commented on May 29, 2024

You can override both the ENTRYPOINT and CMD parts of a dockertfile when running a container:

docker run -v /mydir:/mydir --entrypoint=/mydir/start.sh hurlenko/filebrowser --root=/mydir/data --database=/mydir/config/filebrowser.db

I have no experience with fly.io, not sure if it is possible to do this via their platform. As for the proposals - I believe it might break existing setups, don't really want to do that.

from filebrowser-docker.

mrbodich avatar mrbodich commented on May 29, 2024

You don't run docker command when deploy to fly.io, so unfortunately that's not an option.
I will stay with my own build then based on your Dockerfile and get.sh.

I think you can fix that so it will work for old users. Just add .filebrowser.yaml

version: 3
address: 0.0.0.0
root: /data
database: /config/filebrowser.db

And copy it in Dockerfile

COPY /.filebrowser.yaml /.filebrowser.yaml

The priority listed here https://filebrowser.org/cli/filebrowser will let us override properties easily with ENVs or replace .filebrowser.yaml in simple Dockerfile not recreating whole workflow just to set own variables.
Those users who did not do this setup will still have the same properties you did, but with ability to override using different techniques like set another config with flag, replace .filebrowser.yaml with own, use ENVs.

Flags have highest priority that makes your image braking original customisation. So, that was my suggestion how to fix that.

from filebrowser-docker.

mrbodich avatar mrbodich commented on May 29, 2024

Just an example of my props. I've also added Nginx to the image to use another subpath.
host/browser/ - filebrowser
host/shared/ - proxied direct link to content in shared folder

root: /data/data
database: /data/config/database.db

As I mentioned, this config lets me mount one single volume.

from filebrowser-docker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.