PHAR versioning about php-scoper HOT 5 CLOSED

Maybe we can find a hook for that to rely on the commit version, keeping things in sync is always a PITA

from php-scoper.

We'll need to add back a replaceable tag either way to inject the version string. Simplest is probably falling back on git and sed from the makefile, but Box should be able to do that automatically if we disable the "ignore VCS" option in our Finder instance (which is probably more user friendly and preferable in the end).

from php-scoper.

Is this still relevant?

from php-scoper.

Not any longer...though I'm now curious as to why not. It really should be broken!

Here's what I think is happening. We're scoping all files to build, but running box from current directory. So we're using the original box.json configuration (not build/box.json). Git commands are run from the location of the file used, not from within build.

So long as we assume nobody tries running box from inside build, nothing to do here. Of course, that's exactly what I originally tried before you wrote the makefile ;). We may need a --copy-vcs option or similar down the line - I'm not sure I want to assume how users will do things.

from php-scoper.

Actually another thing is that we rely on OcramiusPackageVersion to get the version which gets it from the installed packages not git itself, so we are completely ditching box git version placeholders :)

from php-scoper.