hugobyte / aurras-event-feed-substrate-js Goto Github PK

Description
Missing test case for chain custom types

Suggestion
Add Test case to check if the custom type provided through environment variables is defined in Polkadot Type Registry

I notified something about the mock data preparation in test methods. Can we make more dynamic way to handle the mock data for unit testing purpose ? It's good have a some kind of mock data generator or mock data handler as separate module.

Input test data and expected result should feed from mock generator , so that we can add the different cases to unit test method just adding the different test data instead of writing each unit test method for each cases. And also it help us to use the common test data between different modules.

Line number from 77 to 60 in event.test.ts

" const mockEvents = [
{ "section": "system", "method": "ExtrinsicSuccess" }, { "section": "system", "method": "ExtrinsicSuccess" },
{ "section": "system", "method": "ExtrinsicFailed" }, { "section": "system", "method": "ExtrinsicFailed" },
{ "section": "balance", "method": "ExtrinsicFailed" }, { "section": "balance", "method": "ExtrinsicFailed" },
]; ];"

Environment
Development

Description
User find it diffcult to deploy local version to docker.

Suggestion
Add docker compose configuration for local deployment

Probably move the configuration from commonjs module to typescript and breakdown the functionality to classes and factory methods if necessary to separate files with a single responsibility.

Decide the naming convention for unit test methods.

Unit test method should explain the what part the code is tested by the unit test method.

Logger configurations should be loaded as array of logger configuration objects.

Please Include the below implementation

1. Add the module to validated the array of list in json file.( list of logger configurations). Make it very generic module , so we can use the same json validator in other part also.
2. Parse the single line logger configuration values into proper json structure.
   something like Type : console ,
   Level : Info
   Location : Console output
3. System should assign the proper values each properties regardless the order in the configuration file.
4. Logger Configuration passed through environment variable should have type, level, and location

Link to PR with this issue #2

Environment

Description
Users finding difficulty in specifying custom configuration

Suggestion
Require env using dotenv and nps for serve

Environment
Test

Description
On running yarn test with NODE_ENV=test

Users end up with following error.

console.error WARNING: NODE_ENV value of 'test' did not match any deployment config file names.

Suggestion
Add configuration for Test environment