Giter Club home page Giter Club logo

Comments (10)

hiyouga avatar hiyouga commented on September 12, 2024

Same here, it seems that the new import structure breaks the transformers on the Windows platform: f24f084

https://github.com/hiyouga/LLaMA-Factory/actions/runs/10809410559/job/29987044325

from transformers.

LysandreJik avatar LysandreJik commented on September 12, 2024

Thanks for the report! This should have been fixed here: #33436

from transformers.

LysandreJik avatar LysandreJik commented on September 12, 2024

Could you try updating main and letting me know whether this is fixed on your side?

from transformers.

GregoryBolshakov avatar GregoryBolshakov commented on September 12, 2024

It fixed the problem for me. Best experience ever, just logged in to see if there's the same issue I have, turns out the fix was submitted a minute ago. Tested it and it works!

from transformers.

GregoryBolshakov avatar GregoryBolshakov commented on September 12, 2024

oh wait a second, I just tested it from different environment, it still doesn't work for me

from transformers.

LysandreJik avatar LysandreJik commented on September 12, 2024

Hey @GregoryBolshakov, thanks for the report! Do you get the same error in that different environment?

In that different environment, can you double check whether the latest main was fetched and the runtime restarted? Thank you 🙏

from transformers.

LysandreJik avatar LysandreJik commented on September 12, 2024

It fixed our CI here: huggingface/trl#2051

So any other issues that aren't in our CI definitely should be. Thanks for your help with the reports!

from transformers.

GregoryBolshakov avatar GregoryBolshakov commented on September 12, 2024

sorry for the second comment, it turned out the repository was not pulled on the second machine, I just updated, it works

from transformers.

hiyouga avatar hiyouga commented on September 12, 2024

Fixed here

from transformers.

LysandreJik avatar LysandreJik commented on September 12, 2024

Fantastic news! Leaving this issue open a bit more in case others come, will close if no new updates.

Thanks all!

from transformers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.