Giter Club home page Giter Club logo

Comments (2)

amyeroberts avatar amyeroberts commented on August 16, 2024

Hi @lucasMichelis, thanks for opening this issue!

Regarding the processing times, this isn't that surprising. The image processors we currently have are unfortunately pretty slow, as they do everything through list comprehensions and in numpy. Their main purpose is to enable users to quickly go from image -> model in a single step. We're working on improving this and will hopefully be introducing a "fast" version of grounding dino's processor soon c.f. #28847 Until then, I'd recommend using a torchvision pipeline is inference time is important.

For the different in model inference time, it's something we can look into! As the differences aren't huge i.e. not indicative of a bug, it's not something which I can guarantee will be addressed immediately, but we'd like to have comparable numbers. If you or anyone in the community would like to do some investigation and open a PR to make things faster I'd be very happy to review!

cc @EduardoPach

from transformers.

EduardoPach avatar EduardoPach commented on August 16, 2024

@lucasMichelis do you have ninja installed as well? If I'm not mistaken the original implementation uses the custom kernels for the MultiScaleDeformableAttention, but the transformers implementation will only use if you have ninja installed

from transformers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.