Giter Club home page Giter Club logo

Comments (5)

EliMCosta avatar EliMCosta commented on June 20, 2024

I've already made some changes to the code, but I don't think they're enough. For example, I couldn't find how to link to each app's icon, which should appear on the Hugginface. Need a feedback/help before a PR:
main...EliMCosta:huggingface.js:patch-1

from huggingface.js.

EliMCosta avatar EliMCosta commented on June 20, 2024

I've already made some changes to the code, but I don't think they're enough. For example, I couldn't find how to link to each app's icon, which should appear on the Hugginface. Need a feedback/help before a PR: main...EliMCosta:huggingface.js:patch-1

Or someone can do the entire PR to solve this issue..

from huggingface.js.

julien-c avatar julien-c commented on June 20, 2024

hey, thanks for opening this! indeed, the icons are in our internal codebase – we can take care of those.

Can you split the PR into two and make one just for vLLM?

from huggingface.js.

EliMCosta avatar EliMCosta commented on June 20, 2024

hey, thanks for opening this! indeed, the icons are in our internal codebase – we can take care of those.

Can you split the PR into two and make one just for vLLM?

Opened this PR for vLLM: #693

from huggingface.js.

julien-c avatar julien-c commented on June 20, 2024

closing in favor of #693

from huggingface.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.