Comments (4)
I don't feel like I know enough about JSON conventions to have strong feelings about this one way or another. I guess my strongest feeling about it all is that we should strive to make the tasks.json
file that users have to write be as simple as possible, even if it means writing some additional custom code to check/add NAs that aren't present in the actual file. But this is not a strongly held conviction on this.
from schemas.
Under this proposal, is there a way for a hub to specify that a mean
prediction is accepted, but not required? For example, with the current set up (which I agree is awkward):
- a hub that wants the
mean
to be required could specify this via:
"output_types": {
"mean": {
"type_id": {
"required": ["NA"],
"optional": null
},
"value" : {
"type": "integer",
"minimum": 0
}
},
...
}
- a hub that wants the
mean
to be optional could specify this via:
"output_types": {
"mean": {
"type_id": {
"required": null,
"optional": ["NA"]
},
"value" : {
"type": "integer",
"minimum": 0
}
},
...
}
I agree that this is both verbose and kind of confusing, so I'm potentially open to defining another way of setting this up -- but (a) I do think we need the ability to specify whether each output type is required or optional, and (b) although I'm not super happy with the current solution, it does at least have the merit of consistency with the other types...
from schemas.
Personally your suggestion @elray1 feels a bit inconsistent as we've been using required
and optional
to determine valid values of properties rather than the requirement of the property itself. Using "NA" and null to specify optional vs required also feels a bit confusing.
Perhaps using the json schema way of including a "required" property containing a vector of property names that are required might be cleaner?
Feels like this might need a bit of discussion at our next meeting?
from schemas.
Further discussion sounds good. I agree that currently, the primary/most obvious effect of required
and optional
is to specify valid values, and as an unclear byproduct, we also end up specifying whether the property as a whole is required (if it has at least one required value) or optional (if it does not have at least one required value). Separating those things would make it much clearer!
from schemas.
Related Issues (20)
- Add schema support for strings as sample indices in `output_type_id` HOT 2
- Broken link HOT 2
- update default value for model_output_directory HOT 12
- Update authors HOT 1
- Add a property for S3 bucket information? HOT 14
- admin-schema.json: split repository_url property into org name and repository name HOT 3
- update schema to reflect changes in sample output_type
- Notify community of v3.0.0 schema version breaking changes HOT 2
- Allow additional properties? HOT 1
- hubAdmin::validate_hub_config - model metadata information HOT 2
- Add note to README to update hubTemplate whenever a new schema version is released
- remove epidemic week formatting requirements for CDF category values HOT 2
- New value features
- Decimal place in value - new features?
- [ORG NAME CHANGE]: Update repo to hubverse-org organisation name
- Document that for cdf and ordinal pmf output types, output_type_id values should be listed in order
- Introduce a property to fix the `output_type_id` column data type across the hub
- Better test for new schema version releases
- Create property to record derived task IDs
- double check setup for `target_metadata.target_keys`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from schemas.