Giter Club home page Giter Club logo

Comments (3)

codetheweb avatar codetheweb commented on June 2, 2024 5

Note for anyone else who runs into this:

I took a similar approach as @pimterry suggests and did something like this:

const [shouldRenderTable, setShouldRenderTable] = useState(false);

useEffect(() => {
	setShouldRenderTable(true);
}, []);

const portalNode = useMemo(() => {
	if (!shouldRenderTable) {
		return null;
	}

	return portals.createHtmlPortalNode();
}, [shouldRenderTable]);

...

return (
	<div>
		{
			portalNode && (
				<portals.InPortal node={portalNode}>
					<ChildToRender/>
				</portals.InPortal>
			)
		}

...

		{
			portalNode && (
				<portals.OutPortal node={portalNode}/>
			)
		}
	</div>
)

Seems to work fine.

from react-reverse-portal.

HynekS avatar HynekS commented on June 2, 2024 4

@codetheweb Nice solution, thank you. For me, even slightly simpler version works (Gatsby site):

const MyComponent = () => {
  const isSSR = typeof window === "undefined";

  const portalNode = useMemo(() => {
    if (isSSR) {
      return null;
    }
    return portals.createHtmlPortalNode();
  }, []);

  return (
    <div>
      {portalNode && (
        <portals.InPortal node={portalNode}>
          <ChildToRender />
        </portals.InPortal>
      )}
      ...
      {portalNode && <portals.OutPortal node={portalNode} />}
    </div>
  );
};

from react-reverse-portal.

pimterry avatar pimterry commented on June 2, 2024

Yes, that makes sense. I'm not doing SSR myself at all, so I'm unlikely to look at this any time soon, but I'd happily accept PRs.

Although it should be doable I suspect it's complicated to make everything work nicely server side, so as a very first step I'd suggest we simply avoid crashing but render nothing at all, and leave it all to be rendered on the client.

from react-reverse-portal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.