Comments (9)
how about dropping it and use nodes built in mkdir (recursive option) instead?
from node-portfinder.
how about dropping it and use nodes built in mkdir (recursive option) instead?
we have to support node 0.10.x - that said - neither of the above (built in mkdir or promises) can be merged in...
I'm not fully understanding the reasoning here but skimming through some older comments it seems to be related to embedded machines running older node versions? Correct me if I'm wrong though.
My two cents about this is that some systems are using older nodejs versions and will not / cannot update but they would probably not update portfinder
either? I suggest to release a new breaking 2.0.0 release dropping support for older nodejs versions and if needed critical bugfixes could be backported to v1 while v2 could be kept a bit more modern.
mkdirp
can be replaced since Node 10 and Node 10 is so old by now it is end-of-life already (since a year ago). Node 0.10.x is almost 6 years after EOL.
from node-portfinder.
how about dropping it and use nodes built in mkdir (recursive option) instead?
we have to support node 0.10.x - that said - neither of the above (built in mkdir or promises) can be merged in...
is there a security issue here or just 'lets keep node modern' which is totally legit, just not with this lib unfortunately
open to discussion if there is a reason outside of staying modern...
from node-portfinder.
lets keep node modern
it's rather 'lets not depend on deprecated things'
from node-portfinder.
... and use less dependencies and making it smaller
from node-portfinder.
I actually feel the same way and have opened an issue (that I need to clean up b/c it was a brain dump) #122
perhaps it should just say:
'lets not depend on deprecated things'
at least that's what I am trying to say, in a very round about way :)
from node-portfinder.
You should consider updating mkdirp at least to a version that fixes GHSA-xvch-5gv4-984h. See:
isaacs/node-mkdirp#27
https://github.com/substack/minimist/issues/164
from node-portfinder.
mkdirp has a new 0.5.6 version with updated minimist dependency. It should fix the issue for now.
from node-portfinder.
also minimist has been updated tonight, it will go out in the next release this week.
from node-portfinder.
Related Issues (20)
- 【feature request】support to use array as basePort HOT 3
- Should portfinder also have a getPortsPromise function? HOT 2
- Free port still in use HOT 3
- All ports lower than 1024 are closed HOT 2
- Version mismatch on `mkdirp` between `package.json` and `package-lock.json` HOT 1
- Update ci to test new versions of npm HOT 3
- If callback is passed to getPort() then all errors should be returned as first parameter of callback HOT 1
- Webpack doesn't like portfinder HOT 14
- Cluster apps are all on same port instead of different ports HOT 2
- no highestPort ts definition in latest version HOT 2
- Update Readme to Specify NOT to use outside development port finding HOT 1
- Consider Dropping Legacy Support for Node JS 0.10.x HOT 6
- Please update mkdirp from 0.5.5 to 0.5.6 HOT 2
- Update "async" dependency HOT 9
- why mkdirp dependecy? HOT 9
- version 1.0.29 doesn't compile with typescript HOT 4
- `testPort` gets called with `65536`
- Create code of conduct HOT 1
- Before filing a socket not closed issue: understanding async I/O + ordering + OS differences + stability requirements HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-portfinder.