region should default to env about middy-secrets HOT 4 CLOSED

Thank you for your ticket!

Indeed, region should not be set to any value and taken from env variables just with the possibility to overwrite them with options.
My endpoint has been removed, library will discover it automatically using AWS_REGION.
I've updated documentation just with a mention that all AWS options can be overwritten (with link to AWS docs).

It's published as v0.1.1

from middy-secrets.

I would submit a support ticket for that. Good catch.

from middy-secrets.

Looks much cleaner now. One last thing I noticed, I promise.

try {
        const response = JSON.parse(data.SecretString || '{}');
        resolve(response);
      } catch (e) {
        reject(err);
      }

Is this try catch necessary? data is coming from AWS, I find it odd that it would fail to parse requiring this catch to exist.

PS What kind of latency have you observed with AWS Secrets?

from middy-secrets.

This try-catch is kinda required because it's possible to set in AWS SM malformed JSON, like:

and it causes:

Regarding latency - I didn't have opportunity to test it yet. I'm building application from scratch and decided to use SM to speed up this process.

from middy-secrets.