Giter Club home page Giter Club logo

Comments (3)

prince272 avatar prince272 commented on September 23, 2024 1

Okay. I understand. More like headless architecture. that's great!!

from react-dialog-hook.

hstemplewski avatar hstemplewski commented on September 23, 2024

After analyzing your code, I'd suggest you create a provider on your own and use useDialog as a method to manage the dialog state. We don't want to create an additional layer on top of our library to keep it as much universal as we can. Also, the disadvantage after implementing this code would be limiting users to open only one dialog at a time.

from react-dialog-hook.

hstemplewski avatar hstemplewski commented on September 23, 2024

@prince272 You proposed passing a component into the opening function and returning it from the hook. We don't want to make our tool depend on components. Lib itself was made only to manage dialog state, not to be responsible for the component and its rendering. I've added context to be optionally used by users so, feel free to update the package if you are using it. Feel free also to review #11 😄

from react-dialog-hook.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.