Giter Club home page Giter Club logo

Comments (3)

juanjovazquez avatar juanjovazquez commented on August 21, 2024

I totally agree. The situation where a ConstructR node is up but it has been removed from the cluster at the same time would be conflicting or at least inconsistent. Just my two cents. IMHO, the other behaviour could hide a bigger issue in the underlying architecture.

from constructr.

raboof avatar raboof commented on August 21, 2024

Perhaps we should remove the key as soon as MemberLeft/MemberExited?

Should any node try to remove the entry, or just the node that is leaving?

from constructr.

hseeberger avatar hseeberger commented on August 21, 2024

In states MemberLeft and MemberExited the nodes theoretically should still work as seed nodes, hence I think MemberRemoved is the right time.

The other thing might be interesting, though. I don't think it's very important, because (a) there's a TTL on the KV entries and (b) we usually use a couple of seed nodes for joining. You could open a ticket, but currently I'm reluctant on adding stuff / making things more complicated. We need tests first.

from constructr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.