Thread queue not "fair" and not rotated properly about ppsspp HOT 3 CLOSED

I think it's something like this:

• Priorities go from low to high. That is, a higher priority number means that the thread has lower priority.
• There's a "ready queue", of all the threads that are ready to run right now (not WAIT or STOPPED). What RotateReadyQueue does it to put the current thread on the end of this queue, and then walks the queue until it finds another thread that has the same or lower priority number, and context switches to it. This way, threads with a higher priority number will indeed NEVER run after RotateThreadReadyQueue if there are threads with a lower priority around.

I didn't think RotateThreadReadyQueue had an argument?

We need to simply implement this ready queue and insert/remove threads from it when threads wait and stop and resume etc.

Exactly how a regular rescheduling chooses the next thread, I'm not clear about. But I think also there it's the case that if there are ready threads with a lower priority number, a high-priority-number thread will NEVER run.

from ppsspp.

I see, the current thread's priority. That makes sense.

This says it has a parameter but it could definitely be wrong:

http://psp.jim.sh/pspsdk-doc/group__ThreadMan.html#gaa8bc5f547a985ed13ec982bc83c0a895

That said, when passing two separate parameters, different results are very reproducible. If you reverse the calls or etc. So it seems like there's a parameter that does something.

Debugging since I created this issue, I found that the actual problem here might be that wait timers are firing on deleted threads. Making a change to not reuse slots in the kernel object pool, things became fair (and also much slower than the PSP.)

-[Unknown]

from ppsspp.

Can we close this?

from ppsspp.