Comments (3)
If it was 0 impact when disabled, yes, most likely I would merge it unless it required really invasive changes to the code-base. I suggest once you have a design in mind, drop your thoughts here and/or in nostr/telegram and I'll let you know if I foresee any issues.
from strfry.
The only thing about using plugins for read is that calling into another process would add a lot of extra latency. My instinct is that this latency would be too high, especially if many different clients were using it at the same time. Maybe for some relays this would be acceptable?
from strfry.
That sounds like I would have to code it myself? I very certainly want to be able to block based on nip42 authentication very soon. If resources are strained, only serve to authed users. If resources get strained, still, only serve paying users. As relay operator I want to offer a paid service and I want to prioritize the target audience at the expense of the general public, DOS attackers and clients that are buggy and demand the same resources over and over again.
So if I implement this ... would you merge it if the plugin was optional and without impact if not used? Would you require benchmarks?
from strfry.
Related Issues (20)
- Question: How can I most efficiently stream from many relays? HOT 5
- strfry stream segfaults HOT 2
- Implement nip 42 client authentication HOT 8
- "bad event id" on actually valid object. HOT 12
- Parser for x-forwarded-for does not work with IPv6 or multiproxy HOT 3
- Build error on latest master HOT 2
- nip-11 pubkey as bech32 should be rejected or warned or well documented to avoid HOT 2
- Using a Reverse Proxy like e.g. NGINX HOT 3
- strfry distribution channels HOT 2
- Write policy applied to sync? HOT 1
- Large database performance HOT 12
- Document all the secret strfry commands HOT 1
- Can I log the reason for "Request ID too long"? HOT 1
- REQ plugin HOT 1
- Compilation Errors HOT 2
- Trying to install HOT 2
- Dockerfile build fails HOT 1
- MDB_MAP_FULL: Environment mapsize limit reached HOT 5
- Work to change database HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from strfry.