Some times spinners with API calls can get stuck blocking the app. need to make these

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Hi <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Thanks. Created PR <a class="issue-link js-issue-link" data-error-text="Failed to load

Allow user to dismiss spinner early about clienteling HOT 7 CLOSED

hotwax commented on June 19, 2024

Allow user to dismiss spinner early

from clienteling.

Comments (7)

ymaheshwari1 commented on June 19, 2024 1

@mtwn105 Like here (https://github.com/hotwax/clienteling/blob/main/src/app/pages/product/product.ts#L294) when moving to the product-review page, we have started showing the spinner but in case if the routing is not completed then the user will be blocked by the spinner, so need to handle all such cases.

from clienteling.

mtwn105 commented on June 19, 2024

Hi @dt2patel can I try this?

from clienteling.

dt2patel commented on June 19, 2024

Sure!

from clienteling.

mtwn105 commented on June 19, 2024

Hi @dt2patel can you tell me in which component this spinner is?

from clienteling.

ymaheshwari1 commented on June 19, 2024

@mtwn105 You need to handle the situation in all the components where spinner is used and make them dismissible so, if the API takes too long to respond then the user can dismiss the spinner.

from clienteling.

dt2patel commented on June 19, 2024

@ymaheshwari1 can you share a reference link for @mtwn105 to sample.

from clienteling.

mtwn105 commented on June 19, 2024

Thanks. Created PR #11

from clienteling.

Recommend Projects