Giter Club home page Giter Club logo

Comments (7)

andrei-picus-hs avatar andrei-picus-hs commented on August 11, 2024

Myes, it seems like the jQuery plugin wasn't ever made for CommonJS. We could add module.exports and require calls, but we need to be careful with webpack because it understands both AMD and CommonJS and it will choose the first branch in that UMD boilerplate.

We could also make everything CommonJS and use webpack to publish a UMD package to npm/bower.

Leaving this open for ideas and/or PRs.

from grid.

RadValentin avatar RadValentin commented on August 11, 2024

Just wanted to add that the defined module gridlist is incorrect, if it was set to grid-list, the actual name of the package and then it should get resolved ok for AMD without aliases.

from grid.

RadValentin avatar RadValentin commented on August 11, 2024

@johnmee Can you give it a shot (see my previous comment) and submit a PR if it works for you?

from grid.

johnmee avatar johnmee commented on August 11, 2024

A variation to solve this for webpack, without setting up aliases.

window.GridList = require('grid-list/src/gridList.js');
require('imports?define=>false!grid-list/src/jquery.gridList.js');

from grid.

olee avatar olee commented on August 11, 2024

Why wasn't this fixed?
Just changing the import from gridlist to grid-list should fix this problem....

from grid.

valentin-radulescu-hs avatar valentin-radulescu-hs commented on August 11, 2024

@olee You're correct, feel free to open a PR and ping me for code review.

from grid.

valentin-radulescu-hs avatar valentin-radulescu-hs commented on August 11, 2024

@olee fixed in #111

from grid.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.