Comments (7)
Myes, it seems like the jQuery plugin wasn't ever made for CommonJS. We could add module.exports
and require
calls, but we need to be careful with webpack because it understands both AMD and CommonJS and it will choose the first branch in that UMD boilerplate.
We could also make everything CommonJS and use webpack to publish a UMD package to npm/bower.
Leaving this open for ideas and/or PRs.
from grid.
Just wanted to add that the defined module gridlist
is incorrect, if it was set to grid-list
, the actual name of the package and then it should get resolved ok for AMD without aliases.
from grid.
@johnmee Can you give it a shot (see my previous comment) and submit a PR if it works for you?
from grid.
A variation to solve this for webpack, without setting up aliases.
window.GridList = require('grid-list/src/gridList.js');
require('imports?define=>false!grid-list/src/jquery.gridList.js');
from grid.
Why wasn't this fixed?
Just changing the import from gridlist
to grid-list
should fix this problem....
from grid.
@olee You're correct, feel free to open a PR and ping me for code review.
from grid.
from grid.
Related Issues (20)
- Type Definition file HOT 1
- Bower reports mismatch during v0.3.1 installation HOT 1
- Initial render when x and y attributes are not provided works for horizontal direction but in vertical direction it just stacks one under the other. HOT 2
- Enabling and disabling drag and drop HOT 1
- how to size boxes?
- Can jQuery be removed? HOT 7
- Overlapping item
- Integrate with Vuejs
- Needs Accessibility Review
- Minimal required CSS HOT 1
- New items being stack one below previous item
- this._adjustSizeOfItems is not a function
- change direction to ltr and rtl
- Acessing the underlying GridList object from jQuery plugin
- Not working in NodeApp
- The demo website has js errors
- How can I swap object without moving to the right?
- Can't create a grid
- limiting ammount of boxes on load
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from grid.