Comments (6)
Alice-anjali
commented on September 27, 2024
1
Yes I would definitely give it a try! ^_^
from hoodie-client.
gr2m
commented on September 27, 2024
1
can I make a PR for this?
Yes, please :) If you run into any blockers with the tests, let’s discuss there
from hoodie-client.
Alice-anjali
commented on September 27, 2024
Hi I went through the code as well as the APIs of this issue. As you mentioned above that the event is not called 'connect' but 'reconnect' and there are only 3 events declared in the hoodie-connection-status which are 'disconnect, reconnect and reset'. There is no event named 'connect'. So I guess if we just change 'connect' to 'reconnect', would it solve the issue ?
from hoodie-client.
gr2m
commented on September 27, 2024
@Alice-anjali yes, I think so. It might break some tests so these will need to be fixed, too. And if the change does not break any tests, then we should probably add a test for it :) Do you want to give a try?
from hoodie-client.
Alice-anjali
commented on September 27, 2024
I changed 'connect' to 'reconnect' and checked it. There are no tests breaking. @sohini-roy is already writing related test cases in the coverage issue. So, can I make a PR for this?
from hoodie-client.
Alice-anjali
commented on September 27, 2024
I made a PR, please review it. :-)
from hoodie-client.
Related Issues (20)
- An in-range update of uglify-js is breaking the build 🚨 HOT 1
- 💯 test coverage HOT 1
- An in-range update of uglify-js is breaking the build 🚨 HOT 1
- An in-range update of browserify is breaking the build 🚨 HOT 2
- Package hoodie-client for Bower HOT 7
- hoodie.account options are not applied HOT 4
- 'change' event no longer triggered after sign in / sign out HOT 1
- Compacting PouchDB HOT 3
- pass options to plugins
- An in-range update of pouchdb-adapter-http is breaking the build 🚨 HOT 4
- An in-range update of pouchdb-adapter-memory is breaking the build 🚨 HOT 4
- An in-range update of pouchdb-core is breaking the build 🚨 HOT 4
- An in-range update of pouchdb-replication is breaking the build 🚨 HOT 4
- Arguments ignored in custom events HOT 2
- An in-range update of @hoodie/store-client is breaking the build 🚨 HOT 2
- An in-range update of uglify-js is breaking the build 🚨 HOT 14
- Project still alive? HOT 5
- Offline multi-user authentication HOT 5
- Option to set database name respectively split data into multiple databases HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hoodie-client.