Implement hoodie.reset() about hoodie-client HOT 12 CLOSED

Hi 👋

I'm gunna try to make a PR for this tonight. Sound good?

from hoodie-client.

Sounds amazing :) All yours

from hoodie-client.

Hey @danreeves what’s status?

from hoodie-client.

Hi @gr2m, finally had some time to look at this tonight. I've had some issues getting hoodie@next and hoodie-client working together but that's maybe another issue. I've made a WIP PR here: #32

Looking like the right direction?

from hoodie-client.

Awesome I'll check it out tomorrow, thanks a ton!

from hoodie-client.

@gr2m I am not guru in api design, but options.promise = options.promise.then looks ugly for me. can't we just return promise and manage it from callback caller instead?

from hoodie-client.

Yeah I’m wondering if there is a nicer API :) But the one with options.promise is the best shot right now, as we can’t get the value that is returned by event handlers

hoodie.on('reset', function () {
  return new Promise(...) // this goes nowhere
})

hoodie.trigger('reset')

from hoodie-client.

@Guria here’s an alternative API suggestion to intercept things like reset events: #42

from hoodie-client.

@gr2m looks similar to something I was working on to get the .reset() call to be thenable without racing the event listeners: danreeves@9ded20e

edit: because options.promise = options.promise.then didn't appear to be working as expected

from hoodie-client.

@danreeves clever!!

from hoodie-client.

@danreeves let’s put hoodie.reset on hold for now. We have to think about the hooks as we need it for the glue code between hoodie.store and hoodie.account, but hoodie.reset only becomes relevant with plugins which we put out of scope for the first release. I like your options.hooks idea, maybe we can use that implementation for the hooks in sign in / sign out

from hoodie-client.

Yeah, that makes sense

from hoodie-client.