Comments (4)
First of all, thanks for listening to my rant, hope it was useful!
Second, sorry for the delay in response, I saw it, and needed to digest what I thought was the right approach.
Third, you're awesome dude. I'm so glad that someone found something useful with the library!
I'm honestly not sure which is the best way to go with the add-ons. There's no reason you couldn't publish this separately with a dependency on the core Honeycomb library instead of the AspNetCore one.
As MassTransit is more specific, I'm not sure it sits in the repo that well, as I can't maintain that.
That said, keeping things in consistent versions is good, so I'm totally torn.
I'd say that the first thing to do would be to think about separating Honeycomb.MassTransit into it's own repo. Then changing the csproj to point to the Honeycomb package, not the project. Incidentally, it's what I need to do with the AspNetCore project too.
from libhoney-dotnet.
Thank you for doing it ;)
I like when libraries are kept in a single official org, so it's up to you if you want to keep the Honeycomb library as a personal (separate) repo, or to create a dedicated organization (I'm reading more than said
In either case, I'm happy to maintain the MassTransit add-on, wherever it is located
On a side note, I just started a new job, and won't be able to run it in production until next year, probably; but I'm happy to work on it in the meantime.
On another side note, if you want I can spare one hour here and there ...
from libhoney-dotnet.
Added you to a channel in the pollinators slack so we can discuss
from libhoney-dotnet.
Weβre going to close this for now as we're moving more towards supporting OpenTelemetry SDKs. Feel free to re-open if itβs still relevant.
from libhoney-dotnet.
Related Issues (18)
- Support NetCoreApp 3.0 / .Net Core 3.0 HOT 2
- Don't transmit to Honeycomb without an API key HOT 2
- Allow different UserAgent headers per-event HOT 1
- The term TeamId is confusing HOT 4
- Span IDs and Span context propagation is missing HOT 2
- Default SendFrequency is probably wrong HOT 1
- X-Honeycomb-Team not set HOT 2
- HoneycombEventManager doesn't work in Hosted Services HOT 3
- Unable to override the target of the HTTP Post
- Honeycomb package should depend on Newtonsoft.Json HOT 2
- Add dependabot
- No user-agent header passed over HOT 1
- The config should be added by a script in the nuget package HOT 1
- Update for E&S
- Example app is checked in CI
- Possible to make work on .net framework ? HOT 2
- .Net Core Hosted Service? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libhoney-dotnet.