Comments (11)
Thanks for reporting this. There is one known compatibility issue (discovered in the past week) between our test rake task (which relies on Rack's Rack::MockRequest
object and MiniProfiler. This should not affect reporting naturally occurring errors within your application. I'll be fixing this shortly.
from honeybadger-ruby.
Happens for me on Rails 4.0.2, I think it's an issue with the better_errors
gem.
Honestly having the test be broken completely defeats the purpose of the test in the first place, so I hope this gets resolved soon.
from honeybadger-ruby.
@JamesMcMahon are you using the rack-mini-profiler gem?
from honeybadger-ruby.
No, but I am using these three gems,
gem 'better_errors'
gem 'binding_of_caller'
gem 'meta_request'
Which when I disable, makes the rake test work.
I don't see rack-mini-profiler in my Gemfile.lock.
from honeybadger-ruby.
I've determined it's not the mini-profiler issue, because I just fixed that. :)
This appears to be missing rack request data somewhere in the middleware stack. Can you both send me the output of rake middleware
? /cc @mockdeep
Also, are you getting normal error reports from your application otherwise? (I think this is only affecting the test task, but want to make sure)
from honeybadger-ruby.
@JamesMcMahon what versions of those 3 gems do you have?
from honeybadger-ruby.
In production:
use Rack::MiniProfiler
use Honeybadger::Rack
use Rack::Cache
use Rack::SSL
use ActionDispatch::Static
use Rack::Lock
use #<ActiveSupport::Cache::Strategy::LocalCache::Middleware:0x00000003ab8648>
use Rack::Runtime
use Rack::MethodOverride
use ActionDispatch::RequestId
use Rails::Rack::Logger
use ActionDispatch::ShowExceptions
use ActionDispatch::DebugExceptions
use ActionDispatch::RemoteIp
use ActionDispatch::Callbacks
use ActiveRecord::ConnectionAdapters::ConnectionManagement
use ActiveRecord::QueryCache
use ActionDispatch::Cookies
use ActionDispatch::Session::CookieStore
use ActionDispatch::Flash
use ActionDispatch::ParamsParser
use ActionDispatch::Head
use Rack::ConditionalGet
use Rack::ETag
use ActionDispatch::BestStandardsSupport
use MailgunWebhooks::Rack
run Synchroform::Application.routes
from honeybadger-ruby.
Thanks, I found it! :)
I suspected it was how I was disabling the BetterErrors middleware, and that turned out to be it. The insidious part is that it doesn't show the rack exception or backtrace in the test task output, and since it was still reporting an error, it snuck through our tests. I'll release a fix for this today.
from honeybadger-ruby.
Sweet, glad you found it!
from honeybadger-ruby.
Excellent 👍
from honeybadger-ruby.
1.9.5 has been released.
from honeybadger-ruby.
Related Issues (20)
- Documentation and source mismatch with Rails.error.record HOT 1
- `Honeybadger::Config#respond_to?` Always Returns true
- Help suppressing a certain error HOT 4
- Honeybadger CLI errors when the deploy command is called with any option HOT 3
- Minitest: Test Backend Notices Not Added to `Honeybadger::Backend::Test` HOT 9
- Invalid class_name param in documentation HOT 1
- Use nested context from objects where available
- Sidekiq 7.1.5 and later changes number of arguments for error handlers
- Add check-in configuration sync HOT 2
- Automate releases with Github Actions
- Flaky test in JRuby test matrix entry
- Allow check-ins to be made by slug as well as id. HOT 8
- Avoid bundling unnecessary dependencies in published gem HOT 3
- Exceptions raised in jobs from Solid Queue are not automatically reported HOT 10
- Sanitizer#filter_key? returns a warning for Numeric hash keys HOT 5
- ActiveJob premature reporting HOT 2
- ActiveJob rescued exceptions should not be reported HOT 2
- Honeybadger.context returns Honeybadger::Agent when passing a block
- good_job related exception at app startup HOT 8
- exception if active job is configured to use a queue adapter via a class HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from honeybadger-ruby.