Giter Club home page Giter Club logo

Comments (11)

joshuap avatar joshuap commented on July 4, 2024

Thanks for reporting this. There is one known compatibility issue (discovered in the past week) between our test rake task (which relies on Rack's Rack::MockRequest object and MiniProfiler. This should not affect reporting naturally occurring errors within your application. I'll be fixing this shortly.

from honeybadger-ruby.

JamesMcMahon avatar JamesMcMahon commented on July 4, 2024

Happens for me on Rails 4.0.2, I think it's an issue with the better_errors gem.

Honestly having the test be broken completely defeats the purpose of the test in the first place, so I hope this gets resolved soon.

from honeybadger-ruby.

joshuap avatar joshuap commented on July 4, 2024

@JamesMcMahon are you using the rack-mini-profiler gem?

from honeybadger-ruby.

JamesMcMahon avatar JamesMcMahon commented on July 4, 2024

No, but I am using these three gems,

  gem 'better_errors'
  gem 'binding_of_caller'
  gem 'meta_request'

Which when I disable, makes the rake test work.

I don't see rack-mini-profiler in my Gemfile.lock.

from honeybadger-ruby.

joshuap avatar joshuap commented on July 4, 2024

I've determined it's not the mini-profiler issue, because I just fixed that. :)

This appears to be missing rack request data somewhere in the middleware stack. Can you both send me the output of rake middleware? /cc @mockdeep

Also, are you getting normal error reports from your application otherwise? (I think this is only affecting the test task, but want to make sure)

from honeybadger-ruby.

joshuap avatar joshuap commented on July 4, 2024

@JamesMcMahon what versions of those 3 gems do you have?

from honeybadger-ruby.

mockdeep avatar mockdeep commented on July 4, 2024

In production:

use Rack::MiniProfiler
use Honeybadger::Rack
use Rack::Cache
use Rack::SSL
use ActionDispatch::Static
use Rack::Lock
use #<ActiveSupport::Cache::Strategy::LocalCache::Middleware:0x00000003ab8648>
use Rack::Runtime
use Rack::MethodOverride
use ActionDispatch::RequestId
use Rails::Rack::Logger
use ActionDispatch::ShowExceptions
use ActionDispatch::DebugExceptions
use ActionDispatch::RemoteIp
use ActionDispatch::Callbacks
use ActiveRecord::ConnectionAdapters::ConnectionManagement
use ActiveRecord::QueryCache
use ActionDispatch::Cookies
use ActionDispatch::Session::CookieStore
use ActionDispatch::Flash
use ActionDispatch::ParamsParser
use ActionDispatch::Head
use Rack::ConditionalGet
use Rack::ETag
use ActionDispatch::BestStandardsSupport
use MailgunWebhooks::Rack
run Synchroform::Application.routes

from honeybadger-ruby.

joshuap avatar joshuap commented on July 4, 2024

Thanks, I found it! :)

I suspected it was how I was disabling the BetterErrors middleware, and that turned out to be it. The insidious part is that it doesn't show the rack exception or backtrace in the test task output, and since it was still reporting an error, it snuck through our tests. I'll release a fix for this today.

from honeybadger-ruby.

mockdeep avatar mockdeep commented on July 4, 2024

Sweet, glad you found it!

from honeybadger-ruby.

JamesMcMahon avatar JamesMcMahon commented on July 4, 2024

Excellent 👍

from honeybadger-ruby.

joshuap avatar joshuap commented on July 4, 2024

1.9.5 has been released.

from honeybadger-ruby.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.