rake honeybadger:test fails when ActionController is not an App dependency about honeybadger-ruby HOT 8 CLOSED

Your suggestion makes sense to me.

from honeybadger-ruby.

I've forked the repo and will add what I think should work in my case. Expect a PR in the next little bit. Btw, I'm so stoked to get away from airbrake. 😁

from honeybadger-ruby.

Awesome, thanks!

from honeybadger-ruby.

@localshred any movement on this?

Also, what do you mean by "generic notification should be broadcast"? Like a console warning? Or a more appropriate exception that says "You need ActionController to continue"?

from honeybadger-ruby.

@dplummer I'm pretty sure this has been fixed. Our plans to move to honeybadger have stalled out for now so I'm not sure at this point.

The test notification was dependent on actioncontroller being an app dependency (which in my apps case it was not).

from honeybadger-ruby.

@dplummer, is this an issue you are also having? I think the bug is really that there is no "app/controllers/application_controller.rb" file present. I'm not sure how many Rails 3 apps have that scenario; I'd be interested to know, however :).

from honeybadger-ruby.

We're not having this same issue, I was just wondering if it was still a problem or not 😸.

from honeybadger-ruby.

👍 nice! Actually, looking at it now, we do check for ApplicationController and fail gracefully if it doesn't exist, but that happens after it's required:

https://github.com/honeybadger-io/honeybadger-ruby/blob/master/lib/honeybadger/rails3_tasks.rb#L47

Perhaps we just rescue the LoadError exception and call it a day...?

from honeybadger-ruby.