Giter Club home page Giter Club logo

Comments (8)

stympy avatar stympy commented on July 4, 2024

Your suggestion makes sense to me.

from honeybadger-ruby.

localshred avatar localshred commented on July 4, 2024

I've forked the repo and will add what I think should work in my case. Expect a PR in the next little bit. Btw, I'm so stoked to get away from airbrake. 😁

from honeybadger-ruby.

stympy avatar stympy commented on July 4, 2024

Awesome, thanks!

from honeybadger-ruby.

dplummer avatar dplummer commented on July 4, 2024

@localshred any movement on this?

Also, what do you mean by "generic notification should be broadcast"? Like a console warning? Or a more appropriate exception that says "You need ActionController to continue"?

from honeybadger-ruby.

localshred avatar localshred commented on July 4, 2024

@dplummer I'm pretty sure this has been fixed. Our plans to move to honeybadger have stalled out for now so I'm not sure at this point.

The test notification was dependent on actioncontroller being an app dependency (which in my apps case it was not).

from honeybadger-ruby.

joshuap avatar joshuap commented on July 4, 2024

@dplummer, is this an issue you are also having? I think the bug is really that there is no "app/controllers/application_controller.rb" file present. I'm not sure how many Rails 3 apps have that scenario; I'd be interested to know, however :).

from honeybadger-ruby.

dplummer avatar dplummer commented on July 4, 2024

We're not having this same issue, I was just wondering if it was still a problem or not 😸.

from honeybadger-ruby.

joshuap avatar joshuap commented on July 4, 2024

👍 nice! Actually, looking at it now, we do check for ApplicationController and fail gracefully if it doesn't exist, but that happens after it's required:

https://github.com/honeybadger-io/honeybadger-ruby/blob/master/lib/honeybadger/rails3_tasks.rb#L47

Perhaps we just rescue the LoadError exception and call it a day...?

from honeybadger-ruby.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.