Comments (8)
Your suggestion makes sense to me.
from honeybadger-ruby.
I've forked the repo and will add what I think should work in my case. Expect a PR in the next little bit. Btw, I'm so stoked to get away from airbrake. 😁
from honeybadger-ruby.
Awesome, thanks!
from honeybadger-ruby.
@localshred any movement on this?
Also, what do you mean by "generic notification should be broadcast"? Like a console warning? Or a more appropriate exception that says "You need ActionController to continue"?
from honeybadger-ruby.
@dplummer I'm pretty sure this has been fixed. Our plans to move to honeybadger have stalled out for now so I'm not sure at this point.
The test notification was dependent on actioncontroller being an app dependency (which in my apps case it was not).
from honeybadger-ruby.
@dplummer, is this an issue you are also having? I think the bug is really that there is no "app/controllers/application_controller.rb" file present. I'm not sure how many Rails 3 apps have that scenario; I'd be interested to know, however :).
from honeybadger-ruby.
We're not having this same issue, I was just wondering if it was still a problem or not 😸.
from honeybadger-ruby.
👍 nice! Actually, looking at it now, we do check for ApplicationController and fail gracefully if it doesn't exist, but that happens after it's required:
https://github.com/honeybadger-io/honeybadger-ruby/blob/master/lib/honeybadger/rails3_tasks.rb#L47
Perhaps we just rescue the LoadError exception and call it a day...?
from honeybadger-ruby.
Related Issues (20)
- Honeybadger CLI errors when the deploy command is called with any option HOT 3
- Minitest: Test Backend Notices Not Added to `Honeybadger::Backend::Test` HOT 9
- Invalid class_name param in documentation HOT 1
- Use nested context from objects where available
- Sidekiq 7.1.5 and later changes number of arguments for error handlers
- Add check-in configuration sync HOT 2
- Automate releases with Github Actions
- Flaky test in JRuby test matrix entry
- Allow check-ins to be made by slug as well as id. HOT 8
- Avoid bundling unnecessary dependencies in published gem HOT 3
- Exceptions raised in jobs from Solid Queue are not automatically reported HOT 10
- Sanitizer#filter_key? returns a warning for Numeric hash keys HOT 5
- ActiveJob premature reporting HOT 2
- ActiveJob rescued exceptions should not be reported HOT 2
- Honeybadger.context returns Honeybadger::Agent when passing a block
- good_job related exception at app startup HOT 8
- exception if active job is configured to use a queue adapter via a class HOT 3
- Insights support appears to not work on Rails 3.2 HOT 3
- Change `events.ignored` array configuration setting to allow objects
- The `bigdecimal` gem needs to be added as an explicit dependency
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from honeybadger-ruby.