Giter Club home page Giter Club logo

Comments (9)

starrhorne avatar starrhorne commented on June 25, 2024

Thanks for the report. We'll get this fixed and ping you when it's done.

from honeybadger-ruby.

thibaudgg avatar thibaudgg commented on June 25, 2024

👍 We got the same problem here.

from honeybadger-ruby.

starrhorne avatar starrhorne commented on June 25, 2024

Working on this now. Sorry for the inconvenience, guys.

from honeybadger-ruby.

joshuap avatar joshuap commented on June 25, 2024

I get a different error message when I try to parse rack input with the trailing %:

env = Rack::MockRequest.env_for('http://www.example.com/explode', :method => 'POST', :input => 'foo=bar&bar=baz%')
request = Rack::Request.new(env)
request.params

Results in:

ArgumentError: invalid %-encoding (baz%)

Maybe it's the Rack version - that's with 1.5. Also, this seems to be an issue only in Rack >= 1.2.

from honeybadger-ruby.

mheffner avatar mheffner commented on June 25, 2024

@joshuap Right, that's the exception that Honeybadger catches. The message that airbrake generates, in place of parameters, was simply stating that when it tried to upload the parameters req.params threw an exception.

from honeybadger-ruby.

joshuap avatar joshuap commented on June 25, 2024

Either way, it's fixed in those commits. I'll bump the gem version to 1.6.2 later today. Thanks for catching this. :)

from honeybadger-ruby.

mheffner avatar mheffner commented on June 25, 2024

@joshuap Great, thanks for fixing this!

from honeybadger-ruby.

thibaudgg avatar thibaudgg commented on June 25, 2024

Thanks!

from honeybadger-ruby.

brauliobo avatar brauliobo commented on June 25, 2024

I'm having this issue with rack 2.2.3

     TypeError:                                                                                                                                                          
       no implicit conversion of nil into Hash                                                                                                                           
     # /home/braulio/.rvm/gems/ruby-2.5.3/gems/rack-2.2.3/lib/rack/request.rb:469:in `merge'                                                                             
     # /home/braulio/.rvm/gems/ruby-2.5.3/gems/rack-2.2.3/lib/rack/request.rb:469:in `params'                                                                            
     # /home/braulio/.rvm/gems/ruby-2.5.3/gems/rack-2.2.3/lib/rack/request.rb:32:in `params'                                                                             
     # /home/braulio/.rvm/gems/ruby-2.5.3/gems/sinatra-2.0.8.1/lib/sinatra/base.rb:79:in `params'                                                                        
     # /home/braulio/.rvm/gems/ruby-2.5.3/gems/sinatra-2.0.8.1/lib/sinatra/base.rb:1089:in `dispatch!'                                                                   
     # /home/braulio/.rvm/gems/ruby-2.5.3/gems/sinatra-2.0.8.1/lib/sinatra/base.rb:919:in `block in call!'                                                               
     # /home/braulio/.rvm/gems/ruby-2.5.3/gems/sinatra-2.0.8.1/lib/sinatra/base.rb:1072:in `block in invoke'                                                             
     # /home/braulio/.rvm/gems/ruby-2.5.3/gems/sinatra-2.0.8.1/lib/sinatra/base.rb:1072:in `catch'                                                                       
     # /home/braulio/.rvm/gems/ruby-2.5.3/gems/sinatra-2.0.8.1/lib/sinatra/base.rb:1072:in `invoke'                                                                      
     # /home/braulio/.rvm/gems/ruby-2.5.3/gems/sinatra-2.0.8.1/lib/sinatra/base.rb:919:in `call!'                                                                        
     # /home/braulio/.rvm/gems/ruby-2.5.3/gems/sinatra-2.0.8.1/lib/sinatra/base.rb:908:in `call'                                                                         
     # /home/braulio/.rvm/gems/ruby-2.5.3/gems/rack-protection-2.0.8.1/lib/rack/protection/xss_header.rb:18:in `call'
     # /home/braulio/.rvm/gems/ruby-2.5.3/gems/rack-protection-2.0.8.1/lib/rack/protection/path_traversal.rb:16:in `call'
     # /home/braulio/.rvm/gems/ruby-2.5.3/gems/rack-protection-2.0.8.1/lib/rack/protection/json_csrf.rb:26:in `call'
     # /home/braulio/.rvm/gems/ruby-2.5.3/gems/rack-protection-2.0.8.1/lib/rack/protection/base.rb:50:in `call'
     # /home/braulio/.rvm/gems/ruby-2.5.3/gems/rack-protection-2.0.8.1/lib/rack/protection/base.rb:50:in `call'
     # /home/braulio/.rvm/gems/ruby-2.5.3/gems/rack-protection-2.0.8.1/lib/rack/protection/frame_options.rb:31:in `call'
     # /home/braulio/.rvm/gems/ruby-2.5.3/gems/rack-2.2.3/lib/rack/null_logger.rb:11:in `call'
     # /home/braulio/.rvm/gems/ruby-2.5.3/gems/rack-2.2.3/lib/rack/head.rb:12:in `call'
     # /home/braulio/.rvm/gems/ruby-2.5.3/gems/sinatra-2.0.8.1/lib/sinatra/base.rb:194:in `call'
     # /home/braulio/.rvm/gems/ruby-2.5.3/gems/sinatra-2.0.8.1/lib/sinatra/base.rb:1951:in `call'
     # ./lib/agora/json_body_parser.rb:23:in `call'

from honeybadger-ruby.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.