homebridge-evohome about verified HOT 12 CLOSED

@donavanbecker I published a new version to npm (v0.7.1). Would you have a look at it?

from verified.

✅ Pre-checks completed successfully.

from verified.

• - The plugin must successfully install.
• - The plugin must implement the Homebridge Plugin Settings GUI.
• - The plugin must not start unless it is configured.
• - The plugin must not execute post-install scripts that modify the user's system in any way.
• - The plugin must not contain any analytics or calls that enable you to track the user.
• - The plugin must not throw unhandled exceptions, the plugin must catch and log its own errors.
• - The plugin must be published to npm and the source code available on GitHub.
• - The plugin must run on all Active LTS versions of Node.js, at the time of writing this is Node.js v10 and v12.
• - The plugin must not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.
• - If the plugin needs to write files to disk (cache, keys, etc.), it must store them inside the Homebridge storage directory.

The plugin must not throw unhandled exceptions, the plugin must catch and log its own errors.
If receive invalid login or grant, plugin stops homebridge from running.

Error during Login: invalid_grant

from verified.

@luc-ass, you need to call callback([]) in these errors to prevent homebridge from blocking.
https://github.com/luc-ass/homebridge-evohome/blob/master/index.js#L176-L190

from verified.

Just so I can get this right: you did not enter any credentials and homebridge stopped because of this?

from verified.

@luc-ass I added incorrect credentials and it stopped Homebridge from running. The plugin must log it’s own. And must keep Homebridge running even if wrong credentials are inputted.

from verified.

Thank you so much for your input! I fixed the crashing problems if no or wrong credentials are set up.

I don’t quite understand what “must log it’s own” is supposed to mean. Could you elaborate? Am I supposed to create a separate log file?

from verified.

I don’t quite understand what “must log it’s own” is supposed to mean. Could you elaborate? Am I supposed to create a separate log file?

Sorry, my wording was wrong. what you changed was exactly what I was meaning. Everything looks good. I will get it on the verified list as soon as I can.

from verified.

/check

from verified.

✅ Pre-checks completed successfully.

from verified.

from verified.

@donavanbecker we have run into problems because of the empty callback. This causes the accessories to be removed if the server doesn't respond (for example because of maintenance). Is there an alternative to callback([]), that prevents the plugin from blocking and marks existing accessories as "Not responding"? So far my searches didn't result in a solution...

from verified.