Improve caveats handling for API installs about brew HOT 8 OPEN

I can see how this might be our most viable fix, but I'd strongly prefer a solution that retains the if and unless calls here.

I can't see how this can be made to work with the API unless we're embedding Ruby source.

from brew.

I solved the problem by just uninstalling and installing again postgresql@14 and then manually running

initdb --locale=C -E UTF-8 /usr/local/var/postgresql@14

which should have been run automatically, according to the message we see when we install postgresql@14

...
This formula has created a default database cluster with:
  initdb --locale=C -E UTF-8 /usr/local/var/postgresql@14
For more details, read:
  https://www.postgresql.org/docs/14/app-initdb.html
...

So, there's a bug either in the installation or documentation/message

from brew.

The caveats¹ should've shown you how to handle this but this doesn't interact well with API installs. So that is a bug. CC @Homebrew/brew

from brew.

Agreed on 🐛. Fix should be:

• print caveats unconditionally in this case
• add a RuboCop to avoid if/unless in caveats

from brew.

Agreed on 🐛. Fix should be:

• print caveats unconditionally in this case

• add a RuboCop to avoid if/unless in caveats

I can see how this might be our most viable fix, but I'd strongly prefer a solution that retains the if and unless calls here.

Many users blindly run what caveats show them, so I'd like to avoid showing them commands we know they don't need to run. Adding notes that most users can ignore to caveats will also tend to make them ignore ones they shouldn't.

from brew.

I can't see how this can be made to work with the API unless we're embedding Ruby source.

I'm not opposed to that, but I don't think we need to. There is already a mechanism for fetching the Ruby source separately, which is why we have the ruby_source_checksum in the API JSON. Alternatively, the Ruby source is in the bottle, so we can read that after pouring and update the caveats from there.

from brew.

Alternatively, the Ruby source is in the bottle, so we can read that after pouring and update the caveats from there.

This would work. Would mean it's not going to show with brew info before installation, in case that matters.

from brew.

Would mean it's not going to show with brew info before installation, in case that matters.

This is fine with me, I think.

from brew.