Last digit of formula version number can be omitted when upgrading about brew HOT 4 CLOSED

Cannot reproduce:

mikebook # brew upgrade lilypond-unstable                                                  
==> Downloading https://formulae.brew.sh/api/formula.jws.json
#=#=- #                                                                                              
==> Downloading https://formulae.brew.sh/api/cask.jws.json
#=#=- #                                                                                              
==> Upgrading 1 outdated package:
nwhetsell/lilypond/lilypond-unstable 2.25.13 -> 2.25.14
==> Fetching nwhetsell/lilypond/lilypond-unstable
==> Downloading https://github.com/nwhetsell/homebrew-lilypond/releases/download/lilypond-unstable-2.2
Already downloaded: /opt/workbrew/home/Library/Caches/Homebrew/downloads/a4adb36076d79d01ef065b9c904b0e7085b7557be98daba79c1a35d5fc2aede1--lilypond-unstable-2.25.14.arm64_sonoma.bottle.tar.gz
==> Upgrading nwhetsell/lilypond/lilypond-unstable
  2.25.13 -> 2.25.14 

• This issue's title and/or description do not reference a single formula e.g. brew install wget.

Please ensure you can reproduce this sort of things with multiple core formulae in future.

from brew.

@MikeMcQuaid Thank you for taking a look at this and for all your work on Homebrew.

I’m not sure why this wasn’t reproducible (sorry about that!), but having taken a closer look, the nature of (what seems to be) the issue suggests that it may not be possible to reproduce this with core formulae, because there is no core formula with a sufficiently long name. The fundamental issue appears to be that a string that contains a newline is passed to Tty.truncate, which then truncates the string as if it was too long for a terminal.

It looks like the affected upgrade message is printed here:

oh1 <<~EOS
  Upgrading #{Formatter.identifier(formula.full_specified_name)}
    #{version_upgrade} #{fi_options.to_a.join(" ")}
EOS

oh1 passes its argument to oh1_title here:

def oh1(title, truncate: :auto)
  puts oh1_title(title, truncate:)
end

oh1_title passes the title argument to Tty.truncate here:

title = Tty.truncate(title.to_s) if $stdout.tty? && !verbose && truncate == :auto

In this case, the title being truncated is

Upgrading nwhetsell/lilypond/lilypond-unstable
  2.25.13 -> 2.25.14 

That’s 68 characters (note the space character after the version number on the 2nd line). However, there are 5 more characters after Upgrading for the ANSI escape of green, and an additional 5 characters to restore text color at the end of the first line. With the newline at the end of the string, that brings the total to 79 characters:

A common terminal width is 80 characters (the default width in Tty), Tty.truncate truncates strings to have 4 fewer characters than the terminal width, so truncated strings typically have 76 characters. When the affected message is truncated to 76 characters, the last character (at index 75) happens to be the penultimate digit of the new version number, so it appears that the last digit is omitted.

from brew.

@nwhetsell We'd review a PR to make the second line of the oh1 a plain old puts instead (the first line should continue to use oh1 and be truncated when necessary.

from brew.

That’s 68 characters (note the space character after the version number on the 2nd line). However, there are 5 more characters after Upgrading for the ANSI escape of green, and an additional 5 characters to restore text color at the end of the first line. With the newline at the end of the string, that brings the total to 79 characters:

Ideally we wouldn't count non-printable characters when deciding where to truncate strings but that's not the main issue here.

from brew.