Giter Club home page Giter Club logo

Comments (13)

joostlek avatar joostlek commented on September 18, 2024 1

Just trying to be clear, I don't mean to be offensive

from core.

home-assistant avatar home-assistant commented on September 18, 2024

Hey there @mtdcr, mind taking a look at this issue as it has been labeled with an integration (aten_pe) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of aten_pe can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign aten_pe Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


aten_pe documentation
aten_pe source
(message by IssueLinks)

from core.

saya6k avatar saya6k commented on September 18, 2024

I'm also getting this issue.

from core.

joostlek avatar joostlek commented on September 18, 2024

Someone needs to bump the dependency and test it out

from core.

saya6k avatar saya6k commented on September 18, 2024

I have tested the code owner's HACS repo with the PE8108G (latest firmware: 2.4.239), and it's working fine. However, the owner appears to have been inactive for a few months...

from core.

joostlek avatar joostlek commented on September 18, 2024

If your issue is around the custom integration, this isn't the place to get support

from core.

saya6k avatar saya6k commented on September 18, 2024

Just sharing some information for someone who's desperately looking to integrate a PDU right now, man... Why so offensive? I'm also having trouble with the official integration.

from core.

mtdcr avatar mtdcr commented on September 18, 2024

I have tested the code owner's HACS repo with the PE8108G (latest firmware: 2.4.239), and it's working fine. However, the owner appears to have been inactive for a few months...

I'd recommend to keep using the HACS repo, as I don't intend to maintain two versions, and trying to maintain the version included in Home Assistant hasn't been a delightful experience to me. Of course I'd be fine with any attempt by others to merge the HACS version into Home Assistant, but I won't invest much time myself.

from core.

joostlek avatar joostlek commented on September 18, 2024

@mtdcr mind having a chat on discord? I'd love to hear your pain and try to help you with them

from core.

mtdcr avatar mtdcr commented on September 18, 2024

@mtdcr mind having a chat on discord? I'd love to hear your pain and try to help you with them

No, sorry, I'm not on discord. To sum it up, there were too many occurrences of "Thank you for your contribution, but we force you to do this huge unrelated extra task before we accept your small incremental improvement" paired with too many pointless discussion in the area of networking and security basics. My time is limited.

from core.

joostlek avatar joostlek commented on September 18, 2024

Is there any way I can help you out with these tasks?

from core.

mtdcr avatar mtdcr commented on September 18, 2024

For this specific issue:

More generally (IMO the more desirable way of helping), in case you (as in "the maintainers of Home Assistant") want to create a more welcoming space:

  • Stop forcing contributors to maintain code repositories and releases for libraries used exclusively by Home Assistant. Let them decide what's best for their integration. This is the reason why this very issue exists. atenpdu broke multiple times already, because Home Assistant at some point in time updated or replaced its pysnmp dependency to incompatible versions without patching atenpdu at the same time (or giving a heads up at least). This could have been easily done tree-wide if the few relevant lines of code in atenpdu were part of the integration.
  • Accept imperfect contributions, especially for new integrations. Let there be space for incremental improvement. Accept that people will choose the way of least resistance eventually. If the hurdles are too high for a few-weekends-per-year pet project, many developers will just give up and find a different solution (like HACS, keeping their code to themselves or moving to an entirely different system).
  • Stop closing issues with a bot. Issues do not disappear magically due to inactivity. Yes, some problems disappear unnoticed, but not those where most of the issue comments only get written to stop the bot until everybody just gives up. That's just rude.

These are examples of failed PRs I submitted in the past, that wasted a considerable amount of my and other people's lifetime and killed most of my motivation (just in case you're interested, I don't intend to warm these up):

from core.

joostlek avatar joostlek commented on September 18, 2024

From your comments I feel like you disagree with the goals of the project. I can't help you with that. I personally strive for consistent and good Integrations that make use of best practices.

If the problem was that you couldn't get the config flow in, I'd gladly help you with that, but I feel like you've given up so I don't feel like investing time either.

I take your other comments with me. I probably can't act on them, but it's interesting for me to see why people don't like contributing to core.

But let's not continue this discussion about contributing to core in this issue as this issue is meant for aten_pe

from core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.