Giter Club home page Giter Club logo

Comments (11)

TheJulianJES avatar TheJulianJES commented on June 29, 2024 1

I can also confirm the issue with an input boolean and this automation:

alias: Test Restart Automation
description: ""
trigger:
  - platform: state
    entity_id:
      - input_boolean.test_input_boolean
    to: "on"
  - platform: state
    entity_id:
      - input_boolean.test_input_boolean
    to: "on"
  - platform: state
    entity_id:
      - input_boolean.test_input_boolean
    to: "on"
condition: []
action:
  - delay:
      hours: 0
      minutes: 0
      seconds: 1
      milliseconds: 0
  - service: notify.julian_telegram
    metadata: {}
    data:
      message: test
mode: restart

Depending on how long the service takes to execute, the delay might not even be needed(?)
But with it, I can reproduce the issue 100%. Currently running core 2024.6.0.

I've definitely also seen this in some actual (light-related) automations that have the restart mode.

@bdraco You already had fixed some similar issues where script/automations cancelled in restart mode in previous releases. Are you aware of any other issues with this? (or have some time to also take a look at this? 😄 )

from core.

bdraco avatar bdraco commented on June 29, 2024 1

I have fixed a few ones recently, but this looks different. Is there a minimal reliable reproducer available?

from core.

TheJulianJES avatar TheJulianJES commented on June 29, 2024 1

Yeah, see the automation I have in my comment above. That's as minimal I was able to get it with reproducing consistently.
You just need to create an input boolean and test that automation.
Oh, and might wanna change the service at the end (send a notification in my example—it can do anything, doesn't really matter, as the automation doesn't get to that point when looking at the traces).

There's also one automation in the initial post.

from core.

bdraco avatar bdraco commented on June 29, 2024 1

@TheJulianJES @LucasCZE
Can you confirmed the linked PR #119100 fixes this problem?

from core.

LucasCZE avatar LucasCZE commented on June 29, 2024 1

Just FYI, I updated my HA to 2024.6.3 (the fix was included in 2024.6.2) and the issue is fixed also in my environment. 👍

from core.

home-assistant avatar home-assistant commented on June 29, 2024

Hey there @home-assistant/core, mind taking a look at this issue as it has been labeled with an integration (automation) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of automation can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign automation Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


automation documentation
automation source
(message by IssueLinks)

from core.

TheJulianJES avatar TheJulianJES commented on June 29, 2024

I think I've actually seen similar behavior with restart automations in 2024.5.x and 2024.6.x.

from core.

LucasCZE avatar LucasCZE commented on June 29, 2024

I also see this issue with a real automation for my window blind. The automation is quite complex and I can see it almost every day. The example YAML I have included is just for the demonstration, but the issue can easily occur even in a real case of use.

from core.

TheJulianJES avatar TheJulianJES commented on June 29, 2024

Did a quick test with the example I had in my comment above and the issue seems to be fixed then.
And as always, thanks for your work!

From the automation traces, the first automation run got into the delay and was restarted then:
image

The second run was restarted before it even got to the delay:
image

And as expected, with the fix, the last run completed now:
image

That's just an observation, the fixed behavior seems fine to me.

from core.

bdraco avatar bdraco commented on June 29, 2024

Thanks for testing!

from core.

LucasCZE avatar LucasCZE commented on June 29, 2024

Thanks for the fix @bdraco and thanks for testing it @TheJulianJES. I really don't know how to test the fix. But as per the comment above, I believe the bug is fixed. Thank you again. 👍

from core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.