Esphome device identifiers missing about core HOT 13 CLOSED

@bdraco
I created my first architecture discussion. Hope I did it in the right way.
In the mean time, I managed to get the one method working in pyscript (cool):

@service(supports_response="only")
def entity_integration(entity_id: str):
    """Get the integration of an entity."""
    # fallback to just returning all entities for a domain
    from homeassistant.helpers.entity import entity_sources
    sources = entity_sources(hass)
    if entity_id in sources:
        return {"success":True, "result":sources[entity_id]["domain"]}
    return {"success":False, "result": None}

from core.

Hey there @OttoWinter, @jesserockz, @kbx81, @bdraco, mind taking a look at this issue as it has been labeled with an integration (esphome) you are listed as a code owner for? Thanks!

_{^{(message by CodeOwnersMention)}}

esphome documentation
esphome source
_{^{(message by IssueLinks)}}

from core.

This is expected. A device required connections OR identifiers, but may use both. ESPHome only uses connections as there is no internal need for identifiers as the mac is always known in all places:

from core.

@bdraco Thanks for educating 👍
Bad luck for me, I use identifiers to lookup the integration that owns the device

from core.

While I don't know your specific use case, device_attr should be able to lookup connections as well

This is how devices are usually looked up

from core.

Hi @bdraco

Just to explain, not a feature request.
My use case is to programmatically lookup the integration that owns an entity. I searched and googled, but this seems not supported.

Currently my approach is far from solid (I Know):

• It only works for entities that are part of a device and support the attribute 'identifiers'.
• it fails when devices own entities from multiple integrations

My template code to lookup the owning integration.

  {%- set ids = device_attr(entity_id, 'identifiers') -%}
  {%- set integration = 'unknown' if (not ids or ids|list|length == 0 or ids|list|first|length!=2) else ids|list|first|first -%}

This works for the majority, but fat from all entities.

The connections device attribute can indeed be queried, but the Mac doesn't help me to distill the integration:

{('mac', 'cc:8d:a2:50:90:e8')}

Bottom line two template methods are missing:

• get_integrations() -> list
• entity_integration(entity_id) -> string

Best Eric

from core.

Bottom line two template methods are missing:

• get_integrations() -> list
• entity_integration(entity_id) -> string

Your template code trying to effectively reimplement a limited version entity_sources because its not exposed to the template engine.

from core.

These can both be likely implemented with a few lines of code to wrap the existing functions as the backends already exist.

If you plan on adding these new functions to the template engine I'd start with an architecture discussion https://github.com/home-assistant/architecture/discussions

from core.

I'm not really experienced in python and github delivery processes, but I can give it a try. Thanks for the information.

from core.

This commit is a rough implementation (without tests) 3270cad

I only did light testing with it

from core.

That looks really great and so simple it would be pity when we don't add it ☺️
If I start and drive the discussion, would you be willing to deliver this when the discussing ends positive?

from core.

I'm happy to write the code if the architecture discussion results in acceptance. Its not something I would use so it needs architecture champion who is willing to advocate for it.

from core.

Great thanks for your support 👍 I will be the ☺️
My first architectural discussion, looking forward how that evolves. will initiate it tomorrow

from core.