Giter Club home page Giter Club logo

Comments (12)

zxdavb avatar zxdavb commented on June 25, 2024 1

Is there something I can help with?

I think it's time to get config flow into this integration. Here's where I'll be working on it: origin/evo_config_flow

from core.

home-assistant avatar home-assistant commented on June 25, 2024

Hey there @zxdavb, mind taking a look at this issue as it has been labeled with an integration (evohome) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of evohome can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign evohome Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


evohome documentation
evohome source
(message by IssueLinks)

from core.

aidanlane avatar aidanlane commented on June 25, 2024

These work correct when using evohome-async client:

On: await tcs.set_mode(SystemMode.HEAT)
Off: await tcs.set_mode(SystemMode.OFF)

from core.

aidanlane avatar aidanlane commented on June 25, 2024

This also works correctly with evohome-async client:

child: HotWater | Zone = tcs.zones_by_id['REDACTED']
print(child.temperature)
await child.set_temperature(19.0)

from core.

zxdavb avatar zxdavb commented on June 25, 2024

Thanks for your submission. This integration was written for - tested on - evohome. It should be able to support all TCC-based systems, but their are some subtle differences:

  • for 'off' this integration uses HeatingOff (as per evohome), whereas FocusPro requires Off. This should be easy enough to fix.
  • FocusPro supports a VacationHold mode for zones whereas that evohome does not
  • and other differences

This should be fixed easily enough, but there are two confounding factors:

  • HA is reluctant to accept any improvements to integrations until after that have been modified to use config flow... evohome does not yet support config flow
  • the scheme that evohome uses within HA is not compatible with HomeKit, etc. Fixing that will be a breaking change - and that should be fixed before adding support for FocusPro

from core.

zxdavb avatar zxdavb commented on June 25, 2024

For EvoTouch (EvoTouch/HeatingZone) temperature control systems (TCSs, aka controllers) we have the following allowedSystemModes:

{"systemMode": "HeatingOff",    "canBePermanent": true, "canBeTemporary": false},
{"systemMode": "Auto",          "canBePermanent": true, "canBeTemporary": false},
{"systemMode": "AutoWithReset", "canBePermanent": true, "canBeTemporary": false},
{"systemMode": "AutoWithEco",   "canBePermanent": true, "canBeTemporary": true, "maxDuration":  "1.00:00:00", "timingResolution":   "01:00:00", "timingMode": "Duration"},
{"systemMode": "Away",          "canBePermanent": true, "canBeTemporary": true, "maxDuration": "99.00:00:00", "timingResolution": "1.00:00:00", "timingMode": "Period"},
{"systemMode": "DayOff",        "canBePermanent": true, "canBeTemporary": true, "maxDuration": "99.00:00:00", "timingResolution": "1.00:00:00", "timingMode": "Period"},
{"systemMode": "Custom",        "canBePermanent": true, "canBeTemporary": true, "maxDuration": "99.00:00:00", "timingResolution": "1.00:00:00", "timingMode": "Period"}

Later versions of the above definitely can support Cool mode, but I am yet to receive the corresponding JSON.

For EvoTouch/RoundWireless and EvoTouch/RoundModulation TCSs we have the following allowedSystemModes:

{"systemMode": "HeatingOff",    "canBePermanent": true, "canBeTemporary": false}
{"systemMode": "Auto",          "canBePermanent": true, "canBeTemporary": false},
{"systemMode": "AutoWithEco",   "canBePermanent": true, "canBeTemporary": true, "maxDuration":  "1.00:00:00", "timingResolution":   "01:00:00", "timingMode": "Duration"},
{"systemMode": "Away",          "canBePermanent": true, "canBeTemporary": true, "maxDuration": "99.00:00:00", "timingResolution": "1.00:00:00", "timingMode": "Period"},

These systems are simply a subset of the first schema, above.

However, for FocusProWifi TCSs we have the following allowedSystemModes:

{"systemMode": "Off",           "canBePermanent": true, "canBeTemporary": false},
{"systemMode": "Heat",          "canBePermanent": true, "canBeTemporary": false},
{"systemMode": "Cool",          "canBePermanent": true, "canBeTemporary": false}

Not all systems support Cool (in which case that mode is absent).

from core.

zxdavb avatar zxdavb commented on June 25, 2024

There are other differences. Regarding zone modes...

For all EvoTouch zones, we have the following allowedSetpointModes

["PermanentOverride", "FollowSchedule", "TemporaryOverride"]

However, for FocusProWifi zones we have:

["PermanentOverride", "FollowSchedule", "TemporaryOverride", "VacationHold"],

from core.

zxdavb avatar zxdavb commented on June 25, 2024

I note the following issues, which are relevant here:

from core.

aidanlane avatar aidanlane commented on June 25, 2024

Thanks for your super speedy reply, insights, and research @zxdavb!

Is there something I can help with?
I can put my old coding hat back onπŸ˜‰ and help with some of the blockers.

from core.

zxdavb avatar zxdavb commented on June 25, 2024

This is the first PR: #118385

from core.

aidanlane avatar aidanlane commented on June 25, 2024

Exciting! Let me know if you want me to test anything πŸ‘

from core.

zxdavb avatar zxdavb commented on June 25, 2024

I am still working on this - latest PR is #119432

from core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.