Giter Club home page Giter Club logo

Comments (4)

hoetmaaiers avatar hoetmaaiers commented on July 26, 2024

Hi, I'm not totally sure what you mean.
Can you try to define te problem? Or pointing towards a solution for your issue?

from ogone-rails.

markmeeus avatar markmeeus commented on July 26, 2024

Sure,

In check_auth.rb on line 46, there is this:

:order_id => (@request['orderID']).to_i

It basically assumes that one uses integer as order_id. In our case, we use mongodb's ids which look like this:

5113b3cb88f929b3a3000001

which will be converted to 5113.
A decent fix would be not to parse to an int at all, but that will probably break current implementations.

Making it configurable on the other hand seems to be a bit overcomplicated ....

from ogone-rails.

hoetmaaiers avatar hoetmaaiers commented on July 26, 2024

Ok, I'll have a look at removing the to_i parsing out of the gem.
On the other hand, the get_params method is only a helper to get more readable params.

from ogone-rails.

hoetmaaiers avatar hoetmaaiers commented on July 26, 2024

Ok, I looked at my own use of get_params and parsing it to an integer in the gem itself is not necesarry.
In the current master branch, the get_params method is updated.

from ogone-rails.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.