Comments (7)
Hoa already uses PSR-2 standards. Code is fixed by PHP-CS-Fixer by hoa devtools:cs
(see https://github.com/hoaproject/Devtools/tree/master/Resource/PHPCSFixer for all configurations and extra fixers).
from compiler.
Hoa already uses PSR-2 standards.
@Hywan Are mutable objects (in particular, the transfer of arguments by reference, like this) are not side effects?
from compiler.
Property names SHOULD NOT be prefixed with a single underscore to indicate protected or private visibility.
The fields declared in this way violate the PSR
from compiler.
Other than this, there are other code problems which are not associated with PSR:
- https://scrutinizer-ci.com/g/SerafimArts/Compiler/?branch=master
- https://scrutinizer-ci.com/g/SerafimArts/Compiler/code-structure/master
=\
from compiler.
Hoa already uses PSR-2 standards.
@Hywan Are mutable objects (in particular, the transfer of arguments by reference, like this) are not side effects?
This algorithm is particularily difficult to implement, and this is an optimisation. I dare you to build the same algorithm with random PSR conventions.
Property names SHOULD NOT be prefixed with a single underscore to indicate protected or private visibility.
The fields declared in this way violate the PSR
“should not”, this is not a “must not” :-). No violation.
Other than this, there are other code problems which are not associated with PSR:
For what I checked, there are full of jokes, stupid code duplication like this:
It gives me an empty page, all sections are empty.
I am totally willing to change Hoa's code, but a compiler is difficult to implement and PSR-2 are only about code style, that we respect :-).
from compiler.
This algorithm is particularily difficult to implement, and this is an optimisation. I dare you to build the same algorithm with random PSR conventions.
:D
“should not”, this is not a “must not” :-). No violation.
=\
It gives me an empty page, all sections are empty.
The link leads to the overall statistics of the code, the places that can be improved. Maybe permissions =(
This is a free service (e.g. you can create the same inspection for hoa) that improves readability and code support. It sometimes buggy, but very often gives very useful advice (for example, about duplicating the code, as you can see).
from compiler.
I think Scrutinizer can help having a better quality for sure. However, this issue is related to PSR. I guess we are OK with that. If you feel a boost of energy, you can open on issue on https://github.com/hoaproject/Central related to Scrutinizer. I am sure some @hoaproject/hoackers will take it :-).
Thanks for the reports!
from compiler.
Related Issues (20)
- Multiple start-symbols support
- Parsing tree is just the first token HOT 1
- Dependabot can't resolve your PHP dependency files
- Backtrack issue when rules overlap HOT 1
- PHP 7.4 deprecation warning in Bin/Pp.php
- Future of Compiler package HOT 4
- Enhance context output of UnrecognizedToken exception
- Enhance context output of UnexpectedToken exception
- Unexpected namespace assignment for PCRE containing colon
- Dependabot can't resolve your PHP dependency files
- Dependabot can't resolve your PHP dependency files
- mbstring problem
- Debug grammar tooling problems
- Bug when saving parser class
- Question: how to access/traverse nodes of grammar HOT 5
- Inlining code of the Parser and license HOT 2
- Madness with exceptions HOT 5
- Remove dependency to `ext/ctype` HOT 4
- Broken visualization of invalid input token in multiline input HOT 7
- Unrecognized Token in Lexer always reports Line 1? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from compiler.