Giter Club home page Giter Club logo

Comments (7)

martincadek avatar martincadek commented on May 20, 2024 1

Could anyone please confirm if anyone has any workaround for this issue? In my case, I'd like to use themes in order to change the default family of fonts. If UpsetR is to be used in scientific journals, most likely it will need to support this. The ideal scenario I wish I could use would be the following:

# using extrafont v0.17; UpSetR v1.3.3; ggplot2 v3.1.0
upset(data = movies, 
      order.by = "freq", 
      keep.order = TRUE,
      mainbar.y.label = "Example plot", 
      point.size = 4, 
      line.size = 1,
      sets.x.label = NULL) +
     theme(text = element_text(family = "Times New Roman"))

But if @JakeConway would be happy to add labels parameter that supports this OR suggest what functions would need to be modified to customise it, that would be really helpful!

from upsetr.

tomlincr avatar tomlincr commented on May 20, 2024 1

@martincadek it seems you can use theme_set() as a workaround for font family, but unfortunately not for font size (which I came here looking for!)

plot_theme = theme_grey() %+replace%  
  theme(text = element_text(family = "Times"))
theme_set(plot_theme)
p = upset(data = movies, 
      order.by = "freq", 
      keep.order = TRUE,
      mainbar.y.label = "Example plot", 
      point.size = 4, 
      line.size = 1,
      sets.x.label = NULL) 
p 

from upsetr.

JakeConway avatar JakeConway commented on May 20, 2024

what are some examples of themes that you would want to implement? there are built in schemes, then theres obviously all of those parameters for full customization. what should we allow?

from upsetr.

ngehlenborg avatar ngehlenborg commented on May 20, 2024

My understanding is that by using the variables defined by the themes we would essentially be able to support any theme: http://docs.ggplot2.org/dev/vignettes/themes.html

from upsetr.

JakeConway avatar JakeConway commented on May 20, 2024

@ngehlenborg : I could add a labels parameter that could control the sizes and maybe fonts to the axis labels, set names, and intersection sizes?

from upsetr.

ngehlenborg avatar ngehlenborg commented on May 20, 2024

My suggestion for themes is motivated by the fact that the list of parameters is already so long. Would it be hard to add support for themes? (which might be more in line of what people are generally doing with plots based on ggplot2)

from upsetr.

JakeConway avatar JakeConway commented on May 20, 2024

How would we specify what plot the theme belongs to?

from upsetr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.