Comments (4)
Hi all, I've implemented a fix for this but it means that readability of a model suffers as you can see in the before and after with and without the fix. (likely why @hlucasfranca purposely chose to overwrite the label text for readability).
Example model without the plugin:
Example model with the plugin (without this fix):
Example model with the plugin (with this fix):
I think it is important to main the colorization of labels as those are generally set to provide some contextual meaning in the model - highlight NIGO routes as an example; however, the Camunda Modeler's chose of dark colors for labels does not play nicely with the dark backgrounds.
Off the top of my head I think of a couple of solutions to this:
- Provide a toggle feature for the dark theme plugin
-- Might be difficult to replace Camunda default css in situ
-- Doesn't solve the problem , just a workaround instead of uninstalling the plugin completely. - Create logic to map the colors to a lighter variant
-- Would be brittle if Camunda Modeler application makes any changes to colors
-- If new colors were added to the pallete, they would not have a mapped value to replace to.
Open to brainstorming and ideas @hlucasfranca @t1
from camunda-modeler-plugin-dracula.
If there is no direct way to change the color of labels in Camunda Modeller, I'd say this plugin is doomed. I don't think that either option is acceptable. Changing to dark-mode must be a viewer-only decision.
So IIUC, we require a PR to the Modeller itself?
from camunda-modeler-plugin-dracula.
I don't see why you would say this plugin is "doomed". This plugin is only changing how the model is visually displayed. It is in now way changing the XML of the BPMN model.
You can change the colors of labels in the model from a choice of 6 colors in the modeler . This is functionality provided by the modeler app. The question I've proposed is regarding what is the best way to visually display the colors in a way that coalesces with a dark theme for readability since those provided 6 colors are rather dark and aren't easily visible on a dark background.
We don't need an update from the modeler to achieve any of this just a decision on which direction to take.
from camunda-modeler-plugin-dracula.
Sorry. Maybe I go you wrong. Can we just provide 6 alternate Dracula colors? They should have a similar hue, so "yellow" is still "yellow". And IIUC these color don't only apply to labels.
from camunda-modeler-plugin-dracula.
Related Issues (6)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from camunda-modeler-plugin-dracula.