Giter Club home page Giter Club logo

Comments (3)

adityanandy avatar adityanandy commented on August 16, 2024

@gianmarco-terrones as a comment on this --> ligands should generally not be stored in the ligands dict as XYZs, but rather as .mol files, which store charge. But I agree this is worth adjusting...

from molsimplify.

gianmarco-terrones avatar gianmarco-terrones commented on August 16, 2024

Resolved! Now using xyz files in ligands.dict works even if the ligands that use the xyz files as geometries are not neutral. Verified that the terachem_input generated has the correct charge by running molsimplify -core iron -geometry oct -lig ooh -oxstate 2 -spin 1. Before, this had the line charge 2. Now, it gives the correct charge of charge -4. ooh uses an xyz as its geometry in ligands.dict and has a charge of -1.

from molsimplify.

gianmarco-terrones avatar gianmarco-terrones commented on August 16, 2024

I should add, the key was @ralf-meyer 's change in molSimplify/Scripts/io.py in the function lig_load. The xyz files were not being given a charge when read by OpenBabel. Ralf fixed this by including the lines

    # Set charge to last entry in ligands.dict
    lig.OBMol.SetTotalCharge(int(dbentry[-1][0]))

from molsimplify.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.