Giter Club home page Giter Club logo

Comments (9)

hismailbulut avatar hismailbulut commented on May 19, 2024 4

I think this is fully implemented as requested.

from neoray.

hismailbulut avatar hismailbulut commented on May 19, 2024 1

This will be a good feature but I need to think and do some research on this. I don't promise that it will be added but I will work on this in my free time.

from neoray.

hismailbulut avatar hismailbulut commented on May 19, 2024

Hi @andis-sprinkis I almost finished all of box drawing and block drawing characters but I used vector library to do that which is same with most of the fonts. This solves gap problem but doesn't solve antialiased smooth lines (which sometimes blurry) and I wanted to ask you which is better? Also who is watching this issue I want to know your ideas.

from neoray.

andis-sprinkis avatar andis-sprinkis commented on May 19, 2024

I do like that the characters are always connected, so I consider it a good improvement over default handling of those glyphs (of font I use - CascadiaCodePL).
Minor thing I keep noticing that radius on round corners chars seems to be off, somewhat stretched (see fzf prompt corners).

Not a fan of antialiasing being applied to rectangular chars as it makes them blurry. I personally prefer the sharp bitmap drawing of these characters on standard DPI.

Looks better than what I get in iterm2 or NeovimQt, but worse than the patched st.

explorer_1jkL2mvCB1
(Neoray with flag FALSE and TRUE)

from neoray.

andis-sprinkis avatar andis-sprinkis commented on May 19, 2024

Result now is tad closer to patched st boxdraw patch rendering, like how htop in terminal buffer looks now :)
VirtualBoxVM_QPd6KCUcfS
(st with boxdraw and Neoray with flag TRUE)

from neoray.

hismailbulut avatar hismailbulut commented on May 19, 2024

Minor thing I keep noticing that radius on round corners chars seems to be off, somewhat stretched (see fzf prompt corners).

Yeah this is my mistake. It's easy to fix.

I like St's drawings but I need to solve a few problems to integrate it directly. The first problem is crosses and curves. I can make the curves by drawing two lines that do not meet in the center as in st, but vector drawing is necessary for the diagonal lines to look good. The second problem is the thickness of the lines. If I set the thin lines to be 1 pixel and the thick lines to be 2, the lines will be very small on high dpi screens (I haven't tested this). Also, since the thin line cannot be drawn in the middle of the thick line, it will still look bad. If I adjust the line thickness dynamically, this time it will be as if I drew vector graphics myself, which will be worse than what the library draws :) If we apply vector and pixel drawing together, the glyphs will not match each other this time. The best solution I've come up with so far is to ignore the thick lines and draw them all the same size. I actually made the current implementation to try it out. Also, I ask you, there is a file named boxdrawingchars.txt in the root folder of the project. I want you to take a screenshot for me by opening the part up to blocks with st in this file. The reason I'm asking you this is because I don't have a linux computer and can't use st. If you post these I can better understand how st draws. Thanks in advance.

from neoray.

hismailbulut avatar hismailbulut commented on May 19, 2024

Sorry your last image actually shows how st draws. I think they are using 1 pixel for thick lines and 3 pixel for bold lines. And they doesn't draw cross lines with this feature. I think this is enough for me.

from neoray.

andis-sprinkis avatar andis-sprinkis commented on May 19, 2024

Well, I hope these are somewhat useful (output from st 8.2 with boxdraw patch):
VirtualBoxVM_W4sjPNN0BX
)
VirtualBoxVM_hs0IUw8A9m

from neoray.

andis-sprinkis avatar andis-sprinkis commented on May 19, 2024

Looks crisp and pleasant to look at 👍
VirtualBoxVM_G2OTAgsQaK

from neoray.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.