Giter Club home page Giter Club logo

Comments (3)

damianwadley avatar damianwadley commented on June 2, 2024

Though this issue was reported before #116 fixed it, the fix is incomplete: alexandrie-index's add_record still requires that the new version be lower than the latest. Perhaps it would be best to remove that check entirely and let the calling code decide whether it wants to add or not?

from alexandrie.

jcgruenhage avatar jcgruenhage commented on June 2, 2024

Aside of whether that should be an error at all: VersionTooLow is duplicated in both alexandrie_index::IndexError and in alexandrie::AlexError. This should be handled in either the API or the index. The problem that #116 doesn't fix this in all the places is caused by this duplication IMO, so in my fix (PR incoming soon) I've fixed that by removing the check from the index.

from alexandrie.

Hirevo avatar Hirevo commented on June 2, 2024

This issue is now fixed thanks to the merging of PR #124 from @jcgruenhage.
Thanks a lot for the contribution and sorry again for my way too long of a delay.

from alexandrie.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.