Comments (6)
Hello @gdetrez. I've added that in on the dev branch to just work by default. I hadn't planned on making a release until around late January 2022. Will you be able to compile a version from the dev branch just fine so you can use it? If not, then I can still publish a release so you can use it.
from paperoni.
Thanks @hipstermojo (and happy new year!)
Building the dev branch right now to test the new feature 😄
from paperoni.
Built and tested, and it works great! Thx!
I noticed you used the page title (the content of <title>
in HTML) and not the first heading (usually <h1>
) as the title, any particular reason?
from paperoni.
Hi @gdetrez . Happy new year to you too!
The reason for that is actually trying to remain consistent with the original mozilla readability JS version. It first checks for the title from the <meta>
tags, the <title>
tag and then goes looking for it in the header tags <h1>
and <h2>
tags.
If you're running Firefox, you can try opening the same article in reader view and you should see the same effect over there. If not, please send me the links because that might be a bug in paperoni instead.
Also note, the current commit has some unfinished work that will cause paperoni
to panic/crash if your article can't be extracted. Please keep that in mind 😅
from paperoni.
Thanks for the explanation. That makes sense.
(dev paperoni hasn't crashed on me so far 🤞)
from paperoni.
Alright then. I'll keep this open until I merge all the new changes.
from paperoni.
Related Issues (8)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from paperoni.