dashboard should show default title based on metric being graphed about highlight HOT 14 CLOSED

@ezhil56x see #8579 (comment) for instructions to get started - feel free to work on this issue.

from highlight.

HIG-4662 dashbaord should show default title based on metric being graphed

from highlight.

To implement default titles for metrics being graphed, follow these steps:

1. Update getDefaultMetricConfig in /frontend/src/pages/Dashboards/Metrics.ts:

   • Modify the function to include a default title based on the metric name.

   export const getDefaultMetricConfig = (name: string): DashboardMetricConfig => ({
     name,
     title: `Default Title for ${name}`, // Add this line
     aggregator: MetricAggregator.AVG,
     ...
   });

2. Modify CreateDashboardModal in /frontend/src/pages/Dashboards/components/CreateDashboardModal/CreateDashboardModal.tsx:

   • Ensure the modal uses the default title when creating a new dashboard.

   const handleCreate = () => {
     const defaultConfig = getDefaultMetricConfig(metricName);
     const newDashboard = {
       title: defaultConfig.title, // Use default title
       ...
     };
     ...
   };

3. Update DashboardPage in /frontend/src/pages/Dashboards/pages/Dashboard/DashboardPage.tsx:

   • Ensure the dashboard page displays the default title if no custom title is provided.

   const DashboardPage = ({ dashboard }) => {
     const title = dashboard.title || `Default Title for ${dashboard.metricName}`;
     return (
       <h1>{title}</h1>
       ...
     );
   };

4. Modify GraphingEditor in /frontend/src/pages/Graphing/GraphingEditor.tsx:

   • Ensure the graph editor uses the default title when creating a new graph.

   const handleCreateMetricView = () => {
     const defaultConfig = getDefaultMetricConfig(selectedMetric);
     const newMetricView = {
       title: defaultConfig.title, // Use default title
       ...
     };
     ...
   };

References

/backend/model/model.go
/frontend/src/pages/Graphing/Dashboard.tsx
/frontend/src/pages/Dashboards/Metrics.ts
/frontend/src/pages/Dashboards/components/CreateDashboardModal/CreateDashboardModal.tsx
/frontend/src/pages/Dashboards/pages/Dashboard/DashboardPage.tsx
/frontend/src/pages/Graphing/GraphingEditor.tsx

Ask Greptile

from highlight.

/bounty $50

from highlight.

💎 $50 bounty • Highlight (YC W23)

Payment will be awarded to the first person to successfully merge a PR meeting all requirements. In the event that multiple PRs are submitted for the issue, we will award payment to the highest quality PR (the one that has cleanest code, best test coverage, most thorough, etc.).

Steps to solve:

1. Start working: Comment /attempt #8579 with your implementation plan
2. Submit work: Create a pull request including /claim #8579 in the PR body to claim the bounty
3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to highlight/highlight!

Add a bounty • Share on socials

from highlight.

@Vadman97
What should be the default title?

from highlight.

@neo773 updated the description, thanks

from highlight.

@Vadman97

I would like to work on this.
Currently for all Metrics the title is Dashboard. But the goal is to update the title with the Metrics name.
For example if the Metrics name is Insights then the title should be Dashboard - Insights.
Is this what you're expecting?

from highlight.

@ezhil56x please see the description. the default is currently Untitled metric view but should update based on the function / metric that are being graphed. In the description image example, the title should update to CountDistinct(Identifier)

from highlight.

I would like to work on this
Can I get assigned?

from highlight.

/attempt #8579

from highlight.

/attempt #8579

from highlight.

💡 @rajeshj11 submitted a pull request that claims the bounty. You can visit your bounty board to reward.

from highlight.

🎉🎈 @rajeshj11 has been awarded $50! 🎈🎊

• Share on socials
• Give feedback

from highlight.