Time unit sync about highlight HOT 2 CLOSED

HIG-4649 Time unit sync

from highlight.

To synchronize time units across traces, sessions, and custom columns, consider the following steps based on the provided codebase insights:

1. Traces Duration (ns): Utilize getTraceDurationString from /frontend/src/pages/Traces/utils.ts to convert nanoseconds to a human-readable format. This function can serve as a base for standardizing time units across the application.

2. Sessions Active Length (ms): Since session lengths are in milliseconds, create a utility function similar to humanizeDuration in /frontend/src/pages/Traces/utils.ts for converting milliseconds to a standardized format that matches the one used for traces.

3. Custom Columns: For custom columns that involve time units, ensure they use the same human-readable format. If custom columns can contain time-based data, implement a function to detect the unit (ns or ms) and convert it to the standardized format decided upon (e.g., always converting to milliseconds or to a human-readable string).

4. Implementation: Implement these utility functions in a shared utility file accessible by both frontend and backend services to ensure consistency. For backend processing, similar logic can be applied as in sessionInsights/utils/utils.go for session data handling.

5. Frontend Display: Ensure that all frontend components displaying time-related information use these utility functions to present data in a consistent format.

By standardizing the time unit representation across the application, searching and labeling accuracy will be improved. This approach requires modifications in both frontend and backend code to ensure a unified handling of time units.

References

/backend/private-graph/graph/model/models_gen.go
/frontend/src/pages/Traces/utils.ts
/backend/lambda-functions/sessionInsights/utils/utils.go
/__generated/rr/rrweb/rr.js

Ask Greptile

from highlight.