Comments (2)
HIG-4646 Let users know data is sampled
from highlight.
To address the issue of data sampling discrepancies, follow these steps:
-
Backend (logs.go): Modify the
ReadLogs
andReadLogsHistogram
functions to check the main logs table if the sampling table returns no results. Implement a fallback mechanism within these functions.Example change for
ReadLogs
:if len(results) == 0 { // Fallback to main logs table // Re-run the query against LogsTableConfig instead of logsSamplingTableConfig }
-
Frontend (TraceLogs.tsx): Add a UI element (e.g., a banner or tooltip) to inform users about potential count discrepancies due to data sampling. This could be conditionally rendered based on a flag set by the backend indicating whether sampling data was used.
Example UI update:
{isSampled && <Alert message="Data is sampled and counts may not accurately reflect total records." type="warning" />}
-
Documentation/Comments: Update code comments and documentation to clearly explain the logic for handling sampled data and the potential for discrepancies in counts. This will help maintain clarity for future development and debugging.
References
/backend/clickhouse/logs.go
/frontend/src/pages/Traces/TraceLogs.tsx
/backend/clickhouse/migrations/000024_create_logs_sampling_table.up.sql
/backend/clickhouse/migrations/000043_create_traces_sampling_table.up.sql
/docs-content/general/6_product-features/1_session-replay/filtering-sessions.md
/docs-content/general/6_product-features/2_error-monitoring/filtering-errors.md
from highlight.
Related Issues (20)
- Remove trace propagation headers on spans that shouldn't be tracked HOT 1
- OpenAI Prompt to long for traces HOT 1
- Build client in Reflame previews HOT 1
- Cannot search metric_name on metrics product HOT 1
- fix retool connection HOT 1
- Triage issue HOT 2
- Error alert config causing no alerts HOT 1
- Make docs on how to use custom browser opentelemetry to send data to Highlight HOT 1
- Error Monitoring Feedback HOT 1
- Get rid of colored avatar placeholders and replace it with the grey new one HOT 1
- Make default time buckets in graphs more useful HOT 1
- Add design for Video Tutorials in Metrics/Alerts HOT 1
- Update alert documentation HOT 1
- Ability to max(created_date) on session metrics HOT 1
- Fix network request trace view HOT 1
- Look at setting up long task instrumentation HOT 1
- api key for OTEL HOT 1
- click to "freeze" legend, click within legend to open related resources HOT 1
- Performance data not being collected correctly HOT 1
- Improve stacktraces for ruby files HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from highlight.