Giter Club home page Giter Club logo

Comments (2)

linear avatar linear commented on July 23, 2024

HIG-4646 Let users know data is sampled

from highlight.

greptile-apps avatar greptile-apps commented on July 23, 2024

To address the issue of data sampling discrepancies, follow these steps:

  1. Backend (logs.go): Modify the ReadLogs and ReadLogsHistogram functions to check the main logs table if the sampling table returns no results. Implement a fallback mechanism within these functions.

    Example change for ReadLogs:

    if len(results) == 0 {
        // Fallback to main logs table
        // Re-run the query against LogsTableConfig instead of logsSamplingTableConfig
    }
  2. Frontend (TraceLogs.tsx): Add a UI element (e.g., a banner or tooltip) to inform users about potential count discrepancies due to data sampling. This could be conditionally rendered based on a flag set by the backend indicating whether sampling data was used.

    Example UI update:

    {isSampled && <Alert message="Data is sampled and counts may not accurately reflect total records." type="warning" />}
  3. Documentation/Comments: Update code comments and documentation to clearly explain the logic for handling sampled data and the potential for discrepancies in counts. This will help maintain clarity for future development and debugging.

References

/backend/clickhouse/logs.go
/frontend/src/pages/Traces/TraceLogs.tsx
/backend/clickhouse/migrations/000024_create_logs_sampling_table.up.sql
/backend/clickhouse/migrations/000043_create_traces_sampling_table.up.sql
/docs-content/general/6_product-features/1_session-replay/filtering-sessions.md
/docs-content/general/6_product-features/2_error-monitoring/filtering-errors.md

Ask Greptile

from highlight.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.