Max call stack exceeded trying to build flame graph about highlight HOT 3 CLOSED

HIG-3778 Max call stack exceeded trying to build flame graph

from highlight.

One of the issues we're running into here is that we have a lot of duplicate records for spans in our DB so we're returning a bloated number of spans. I've confirmed we have these in both the traces and traces_by_id tables.

In the linked network request that is being inspected, you can see that there are almost 3000 spans returned for the trace, and it seems like around 3/4 of them are from duplicates. This results in tons of overlapping spans which would cause the recursive logic to be triggered a lot than normal for span organization.

We should still look at ways to make the logic more efficient, but I have a hunch that this particular trace would work fine if we didn't have all the duplicate spans.

from highlight.

Also wondering if this could be related to #7366 - another instance where we seem to be storing duplicates when ingesting data into Clickhouse.

from highlight.