[flash-swap] Handle division by zero in "getRepayAmount" function about hifi HOT 3 CLOSED

The Uniswap v2 pair contract will check for the latter to not be greater than the former, but it will allow it to pass when they are equal.

I don't think the above premise is valid. I think this edge case is never reachable due to line 162 in the Uniswap V2 pair contract:

require(amount0Out < _reserve0 && amount1Out < _reserve1, 'UniswapV2: INSUFFICIENT_LIQUIDITY');

When underlyingReserves happens to match underlyingAmount, that means either amount0Out matches _reserve0 or amount1Out matches _reserve1. Which leads to the swap function call being reverted with UniswapV2: INSUFFICIENT_LIQUIDITY even before uniswapV2Call(...) is entered.

from hifi.

Your analysis may be correct, though I am not sure now since it's been a while since I opened this issue. I will let you decide if it should be closed.

from hifi.

Yeah, I think it should be closed.

from hifi.