Auto-quote names not working with Postgres about squel HOT 6 CLOSED

usingValuePlaceholders really only applies when using parameterized values for certain DB engines. For instance when doing an insert you would construct the query as:

squel.insert({ usingValuePlaceholders: true }).into('table').set('field', '?')

// INSERT INTO table (field) VALUES(?)

You would then use your db engine's preferred querying method to replace the ? parameter with an actual value.

from squel.

As for why squel doesn't automatically quote table names and field names it's as I mentioned in a comment: squel needs to be able to support the following:

squel.select().from("db1.table1").field("DATE_FORMAT(db1.table1.when, '%Y-%M-%D')", "Start date")

But I take your and bminer's point that it would be useful to have an option which turns on auto-quoting when you want it. I'll see if I can do that as part of #1.

from squel.

As for the WHERE clause generation not working in your above code I ran it myself against squel 1.0.5 and got the following output:

SELECT "color", "size", "childSku", "Variants"."updatedAt", "listPriceCents", "salePriceCents", "ProductId", "Products"."parentSku", "Products"."title", "Products"."description", "Products"."CategoryId", "Categories"."name", "Categories"."description", "Products"."BrandId", "Brands"."name", "Brands"."description", "Brands"."PartnerId", "Partners"."name" FROM "Variants" LEFT JOIN "Products" ON ("Variants"."ProductId" = "Products"."id") LEFT JOIN "Categories" ON ("Products"."CategoryId" = "Categories"."id") LEFT JOIN "Brands" ON ("Products"."BrandId" = "Brands"."id") LEFT JOIN "Partners" ON ("Brands"."PartnerId" = "Brands"."PartnerId") WHERE (`Variants`.`childSku` = 'puma-1234-red-large')

from squel.

Version 1.0.6 has two new options:

autoQuoteTableNames
autoQuoteFieldNames

Note: you will still need to add your own quotes around names inside where clauses, etc.

from squel.

Am considering this done for now.

from squel.

Yep, thanks for resolving!

from squel.