Can't go back on 1st attempt when betting with insufficient coins. about text-fighter HOT 8 CLOSED

Thanks for confirming. Can I contribute to this issue?

from text-fighter.

@CLEMENTJOHNSHAJI of course, contributions are welcome and appreciated 😄

from text-fighter.

Running Java 8 1.8.0_181 I could not replicate this issue. I thought it may have something to do with the Scanner Infinite Loop issue, but it just worked for me.

I only tested by cutting out the getValidInt() method from the Ui class and the do-while loop from the Casino class.

The int validator and loop seem to work fine. Maybe it has something to do with when it breaks out of the loop from the return statement? Not sure, I tried to help though haha!

from text-fighter.

It might simply just be the Ui.pause() call after the prompt causing an error extra stop in the program.
I cant test this at the moment though, as im not at my computer

from text-fighter.

Yes, you are right. I fixed the issue by converting pause() function in Action.java
from
public static void pause(){
try{
Scanner pauseScan = new Scanner(System.in);
String temp = pauseScan.nextLine();
Ui.println(temp);
}catch (Exception e){
//Blank for a reason - Not supposed to do anything.
}
}

to

public static void pause(){
try{
Scanner pauseScan = new Scanner(System.in);
return;
}catch (Exception e){
//Blank for a reason - Not supposed to do anything.
}
}

from text-fighter.

Doing that just makes the entire pause function essentially do nothing, making it not work at all (which you'll notice in other places the function is used. For example, when you attack an enemy, it won't pause the screen for the user to read the text before going back to the menu.

The problem is that the Ui.pause call shouldnt be there at all. So, in Casino.java, change

if (bet > Coins.get()) {
   Ui.cls();
   bet = 0;
   Ui.println("You do not have enough coins. Please enter a smaller amount. (Or enter 0 to go back)");
   Ui.pause();
}

to

if (bet > Coins.get()) {
   Ui.cls();
   bet = 0;
   Ui.println("You do not have enough coins. Please enter a smaller amount. (Or enter 0 to go back)");
}

Hopefully that makes sense

from text-fighter.

Yes. On working on this, I realized the use of pause() function in other places and did the same change you have suggested in casino.java.

from text-fighter.

I am a beginner, and I am working on this project as part of my coursework. I have to update my contributions in git for the completion of my course. So it would be of great help if you can merge my request.

from text-fighter.