Comments (4)
Hi @HFG43 and @Kidd254, kindly update the link in your issue above to your Github project (kanban board)
from js_capstone.
Hi @HFG43 and @Kidd254
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
✔️ Good Setup
Required Changes ♻️
- Kindly ensure that all cards on your board have been assigned, All cards with group task in the title should be assigned to someone
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
You can also consider:
- N/A
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification @prolajumokeoni.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
from js_capstone.
STATUS: APPROVED 🍾✔🎉
Hello @prolajumokeoni and @Kidd254 👋
Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉
Highlights
- Descriptive PR.
- Correct git-flow.
Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
from js_capstone.
@emmanuellekamwa Thanks for your feedback!
from js_capstone.
Related Issues (20)
- [3pt] - Add reservations counter - Student C
- [3pt] - Add comments counter - Student B
- [3pt] - Add all items counter on the Homepage - Student A HOT 1
- [4pt] - Create feature: add new reservation - Student C
- [4pt] - Create feature: add new comment - Student B
- [3pt] - Create feature: add new like - Student A HOT 1
- [3pt] - Display reservations for a given item on the Reservations pop-up - Student C
- [3pt] - Display comments for a given item on the Comments pop-up - Student B
- [4pt] - Display number of likes for each item on the Homepage - Student A
- [4pt] - Display Reservations pop up with selected item's details - Student C
- [4pt] -Display Comments pop up with selected item's details - Student B
- [4pt] - Display list of items on the Homepage - Student A
- [0.5pt] Add footer - group task HOT 1
- [0.5pt] Add header - group task
- [0.5pt] Set up the project with Webpack and Jest- group task
- [1pt] Choose assets - group task
- [0.5pt] Find external API - group task
- Peer to Peer code review - Morning session HOT 1
- Peer to Peer to code review - Morning session
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from js_capstone.