Giter Club home page Giter Club logo

Comments (2)

Hexagon avatar Hexagon commented on May 14, 2024 2

A proposed fix is pushed, which make second and third argument completely interchangeable.

The reason I cannot use a fixed order is that both

const job = Cron('2023-01-23T00:00:00', { timezone: 'Asia/Kolkata' });

... and ...

const job = Cron('2023-01-23T00:00:00', () => { console.log('Yay') });

... is fully valid.

The first one is usable for checking next occurrance (using job.next() or job.enumerate(). While the second one is used for scheduling.

Previously, only the first of the next two example would work as expected.

const job = Cron('2023-01-23T00:00:00', { timezone: 'Asia/Kolkata' }, () => { console.log('Yay') });

But with the proposed fix, the following would be valid too.

const job = Cron('2023-01-23T00:00:00', () => { console.log('Yay') }, { timezone: 'Asia/Kolkata' });

I also added type checking of these two arguments.

The updated documentation can be seen on

http://hexagon.github.io/croner/Cron.html

from croner.

Hexagon avatar Hexagon commented on May 14, 2024 2

Now released in 4.3.3

from croner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.